From: Jakub Kicinski <kuba@kernel.org>
To: Matthieu Baerts <matttbe@kernel.org>
Cc: Simon Horman <horms@kernel.org>,
mptcp@lists.linux.dev, Mat Martineau <martineau@kernel.org>,
Geliang Tang <geliang@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Gregory Detal <gregory.detal@gmail.com>,
Shuah Khan <shuah@kernel.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-kselftest@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH net 2/3] mptcp: remove unneeded lock when listing scheds
Date: Mon, 28 Oct 2024 15:53:14 -0700 [thread overview]
Message-ID: <20241028155314.006f9063@kernel.org> (raw)
In-Reply-To: <4ca239db-6a05-4735-916c-73cee0ee22a0@kernel.org>
On Wed, 23 Oct 2024 16:13:36 +0200 Matthieu Baerts wrote:
> On 23/10/2024 14:21, Simon Horman wrote:
> > On Mon, Oct 21, 2024 at 12:25:27PM +0200, Matthieu Baerts (NGI0) wrote:
> >> mptcp_get_available_schedulers() needs to iterate over the schedulers'
> >> list only to read the names: it doesn't modify anything there.
> >>
> >> In this case, it is enough to hold the RCU read lock, no need to combine
> >> this with the associated spin lock.
> >>
> >> Fixes: 73c900aa3660 ("mptcp: add net.mptcp.available_schedulers")
> >> Cc: stable@vger.kernel.org
> >> Suggested-by: Paolo Abeni <pabeni@redhat.com>
> >> Reviewed-by: Geliang Tang <geliang@kernel.org>
> >> Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
> >
> > I do wonder if it would be more appropriate to route this via net-next
> > (without a fixes tag) rather than via net. But either way this looks good
> > to me.
> Good point. On one hand, I marked it as a fix, because when working on
> the patch 1/3, we noticed these spin_(un)lock() were not supposed to be
> there in the first place. On the other hand, even it's fixing a small
> performance issue, it is not fixing a regression.
>
> I think it is easier to route this via -net, but I'm fine if it is
> applied in net-next.
I agree with Simon's initial response. Let's not blur the lines.
Please re-queue for net-next, I'll apply the rest.
BTW thanks a lot for proactively fixing the CONFIG_PROVE_RCU_LIST
splats!
next prev parent reply other threads:[~2024-10-28 22:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-21 10:25 [PATCH net 0/3] mptcp: sched: fix some lock issues Matthieu Baerts (NGI0)
2024-10-21 10:25 ` [PATCH net 1/3] mptcp: init: protect sched with rcu_read_lock Matthieu Baerts (NGI0)
2024-10-23 12:19 ` Simon Horman
2024-10-21 10:25 ` [PATCH net 2/3] mptcp: remove unneeded lock when listing scheds Matthieu Baerts (NGI0)
2024-10-23 12:21 ` Simon Horman
2024-10-23 14:13 ` Matthieu Baerts
2024-10-25 10:00 ` Simon Horman
2024-10-28 22:53 ` Jakub Kicinski [this message]
2024-10-21 10:25 ` [PATCH net 3/3] selftests: mptcp: list sysctl data Matthieu Baerts (NGI0)
2024-10-23 12:19 ` Simon Horman
2024-10-28 23:00 ` [PATCH net 0/3] mptcp: sched: fix some lock issues patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241028155314.006f9063@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=geliang@kernel.org \
--cc=gregory.detal@gmail.com \
--cc=horms@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=martineau@kernel.org \
--cc=matttbe@kernel.org \
--cc=mptcp@lists.linux.dev \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).