[PATCH net-next v2] Documentation: networking: Add missing PHY_GET command in the message list

[PATCH net-next v2] Documentation: networking: Add missing PHY_GET command in the message list

[Kory Maincent]

ETHTOOL_MSG_PHY_GET/GET_REPLY/NTF is missing in the ethtool message list.
Add it to the ethool netlink documentation.

Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
---

Change in v2:
- Change PHY_NTF documentation
---
 Documentation/networking/ethtool-netlink.rst | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Documentation/networking/ethtool-netlink.rst b/Documentation/networking/ethtool-netlink.rst
index 295563e91082..b25926071ece 100644
--- a/Documentation/networking/ethtool-netlink.rst
+++ b/Documentation/networking/ethtool-netlink.rst
@@ -236,6 +236,7 @@ Userspace to kernel:
   ``ETHTOOL_MSG_MM_GET``                get MAC merge layer state
   ``ETHTOOL_MSG_MM_SET``                set MAC merge layer parameters
   ``ETHTOOL_MSG_MODULE_FW_FLASH_ACT``   flash transceiver module firmware
+  ``ETHTOOL_MSG_PHY_GET``               get Ethernet PHY information
   ===================================== =================================
 
 Kernel to userspace:
@@ -283,6 +284,8 @@ Kernel to userspace:
   ``ETHTOOL_MSG_PLCA_NTF``                 PLCA RS parameters
   ``ETHTOOL_MSG_MM_GET_REPLY``             MAC merge layer status
   ``ETHTOOL_MSG_MODULE_FW_FLASH_NTF``      transceiver module flash updates
+  ``ETHTOOL_MSG_PHY_GET_REPLY``            Ethernet PHY information
+  ``ETHTOOL_MSG_PHY_NTF``                  Ethernet PHY information change
   ======================================== =================================
 
 ``GET`` requests are sent by userspace applications to retrieve device
-- 
2.34.1

Re: [PATCH net-next v2] Documentation: networking: Add missing PHY_GET command in the message list

[Maxime Chevallier]

Hello Köry,

On Mon, 28 Oct 2024 14:23:51 +0100
Kory Maincent <kory.maincent@bootlin.com> wrote:

> ETHTOOL_MSG_PHY_GET/GET_REPLY/NTF is missing in the ethtool message list.
> Add it to the ethool netlink documentation.
> 
> Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>

Thanks for spotting and fixing this.

Reviewed-by: Maxime Chevallier <maxime.chevallier@bootlin.com>

Maxime

Re: [PATCH net-next v2] Documentation: networking: Add missing PHY_GET command in the message list

[Jakub Kicinski]

On Mon, 28 Oct 2024 14:23:51 +0100 Kory Maincent wrote:
> ETHTOOL_MSG_PHY_GET/GET_REPLY/NTF is missing in the ethtool message list.
> Add it to the ethool netlink documentation.

FTR ETHTOOL_MSG_PHY_NTF is not present in any _released_ kernel, AFAICT.
So we could still delete it in net before 6.12 is cut.
But if there is a plan to use it soon we can as well leave it be.

Re: [PATCH net-next v2] Documentation: networking: Add missing PHY_GET command in the message list

[Maxime Chevallier]

On Tue, 29 Oct 2024 08:08:04 -0700
Jakub Kicinski <kuba@kernel.org> wrote:

> On Mon, 28 Oct 2024 14:23:51 +0100 Kory Maincent wrote:
> > ETHTOOL_MSG_PHY_GET/GET_REPLY/NTF is missing in the ethtool message list.
> > Add it to the ethool netlink documentation.  
> 
> FTR ETHTOOL_MSG_PHY_NTF is not present in any _released_ kernel, AFAICT.
> So we could still delete it in net before 6.12 is cut.
> But if there is a plan to use it soon we can as well leave it be.

Ah true indeed... yes I have a few patches to actually implement that,
I'll try to send that during this cycle.

Thanks,

Maxime

Re: [PATCH net-next v2] Documentation: networking: Add missing PHY_GET command in the message list

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Mon, 28 Oct 2024 14:23:51 +0100 you wrote:
> ETHTOOL_MSG_PHY_GET/GET_REPLY/NTF is missing in the ethtool message list.
> Add it to the ethool netlink documentation.
> 
> Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
> ---
> 
> Change in v2:
> - Change PHY_NTF documentation
> 
> [...]

Here is the summary with links:
  - [net-next,v2] Documentation: networking: Add missing PHY_GET command in the message list
    https://git.kernel.org/netdev/net-next/c/2b1d193a5a57

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html