From: Jakub Kicinski <kuba@kernel.org>
To: Petr Machata <petrm@nvidia.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, <netdev@vger.kernel.org>,
Ido Schimmel <idosch@nvidia.com>,
"Amit Cohen" <amcohen@nvidia.com>,
Vladimir Oltean <vladimir.oltean@nxp.com>, <mlxsw@nvidia.com>
Subject: Re: [PATCH net-next 0/8] net: Shift responsibility for FDB notifications to drivers
Date: Tue, 29 Oct 2024 12:16:19 -0700 [thread overview]
Message-ID: <20241029121619.1a710601@kernel.org> (raw)
In-Reply-To: <cover.1729607879.git.petrm@nvidia.com>
On Tue, 22 Oct 2024 16:50:11 +0200 Petr Machata wrote:
> Besides this approach, we considered just passing a boolean back from the
> driver, which would indicate whether the notification was done. But the
> approach presented here seems cleaner.
What about adding a bit to the ops struct to indicate that
the driver will generate the notification? Seems smaller in
terms of LoC and shifts the responsibility of doing extra
work towards more complex users.
prev parent reply other threads:[~2024-10-29 19:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-22 14:50 [PATCH net-next 0/8] net: Shift responsibility for FDB notifications to drivers Petr Machata
2024-10-22 14:50 ` [PATCH net-next 1/8] net: rtnetlink: Publish rtnl_fdb_notify() Petr Machata
2024-10-22 14:50 ` [PATCH net-next 2/8] ndo_fdb_add: Shift responsibility for notifying to drivers Petr Machata
2024-10-22 14:50 ` [PATCH net-next 3/8] ndo_fdb_del: " Petr Machata
2024-10-22 14:50 ` [PATCH net-next 4/8] selftests: net: lib: Move logging from forwarding/lib.sh here Petr Machata
2024-10-23 20:07 ` Shuah Khan
2024-10-24 10:06 ` Petr Machata
2024-10-22 14:50 ` [PATCH net-next 5/8] selftests: net: lib: Move tests_run " Petr Machata
2024-10-22 14:50 ` [PATCH net-next 6/8] selftests: net: lib: Move checks " Petr Machata
2024-10-22 14:50 ` [PATCH net-next 7/8] selftests: net: lib: Add kill_process Petr Machata
2024-10-22 14:50 ` [PATCH net-next 8/8] selftests: net: fdb_notify: Add a test for FDB notifications Petr Machata
2024-10-29 19:16 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241029121619.1a710601@kernel.org \
--to=kuba@kernel.org \
--cc=amcohen@nvidia.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=idosch@nvidia.com \
--cc=mlxsw@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).