From: Jakub Kicinski <kuba@kernel.org>
To: Sai Krishna <saikrishnag@marvell.com>
Cc: <davem@davemloft.net>, <edumazet@google.com>, <pabeni@redhat.com>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<sgoutham@marvell.com>, <gakula@marvell.com>,
<lcherian@marvell.com>, <jerinj@marvell.com>,
<hkelam@marvell.com>, <sbhatta@marvell.com>,
<kalesh-anakkur.purayil@broadcom.com>
Subject: Re: [net-next PATCH v2 4/6] octeontx2-pf: CN20K mbox REQ/ACK implementation for NIC PF
Date: Tue, 29 Oct 2024 16:06:57 -0700 [thread overview]
Message-ID: <20241029160657.2a0a2c91@kernel.org> (raw)
In-Reply-To: <20241022185410.4036100-5-saikrishnag@marvell.com>
On Wed, 23 Oct 2024 00:24:08 +0530 Sai Krishna wrote:
> +/**
> + * CN20k RVU PF MBOX Interrupt Vector Enumeration
> + *
> + * Vectors 0 - 3 are compatible with pre cn20k and hence
> + * existing macros are being reused.
> + */
Please don't use /** unless the comment is in kernel-doc format.
It causes warnings for documentation extractors:
drivers/net/ethernet/marvell/octeontx2/af/cn20k/struct.h:12: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
* CN20k RVU PF MBOX Interrupt Vector Enumeration
drivers/net/ethernet/marvell/octeontx2/af/cn20k/struct.h:12: warning: missing initial short description on line:
* CN20k RVU PF MBOX Interrupt Vector Enumeration
--
pw-bot: cr
next prev parent reply other threads:[~2024-10-29 23:06 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-22 18:54 [net-next PATCH v2 0/6] CN20K silicon with mbox support Sai Krishna
2024-10-22 18:54 ` [net-next PATCH v2 1/6] octeontx2: Set appropriate PF, VF masks and shifts based on silicon Sai Krishna
2024-11-01 10:08 ` Simon Horman
2024-11-11 9:15 ` Sai Krishna Gajula
2024-10-22 18:54 ` [net-next PATCH v2 2/6] octeontx2-af: CN20k basic mbox operations and structures Sai Krishna
2024-10-22 18:54 ` [net-next PATCH v2 3/6] octeontx2-af: CN20k mbox to support AF REQ/ACK functionality Sai Krishna
2024-11-01 10:18 ` Simon Horman
2024-11-11 8:42 ` Sai Krishna Gajula
2024-10-22 18:54 ` [net-next PATCH v2 4/6] octeontx2-pf: CN20K mbox REQ/ACK implementation for NIC PF Sai Krishna
2024-10-29 23:06 ` Jakub Kicinski [this message]
2024-11-01 5:50 ` Sai Krishna Gajula
2024-10-22 18:54 ` [net-next PATCH v2 5/6] octeontx2-af: CN20K mbox implementation for AF's VF Sai Krishna
2024-10-22 18:54 ` [net-next PATCH v2 6/6] octeontx2-pf: CN20K mbox implementation between PF-VF Sai Krishna
2024-11-01 10:04 ` Simon Horman
2024-11-12 17:48 ` Sai Krishna Gajula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241029160657.2a0a2c91@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gakula@marvell.com \
--cc=hkelam@marvell.com \
--cc=jerinj@marvell.com \
--cc=kalesh-anakkur.purayil@broadcom.com \
--cc=lcherian@marvell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=saikrishnag@marvell.com \
--cc=sbhatta@marvell.com \
--cc=sgoutham@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).