* [PATCH for-next 4/7] selftests/net: Add missing gitignore file [not found] <20241025014010.6533-1-lizhijian@fujitsu.com> @ 2024-10-25 1:40 ` Li Zhijian 2024-10-29 23:33 ` Jakub Kicinski 2024-10-25 1:40 ` [PATCH for-next 7/7] selftests/net: Fix ./ns-XXXXXX not cleanup Li Zhijian 1 sibling, 1 reply; 6+ messages in thread From: Li Zhijian @ 2024-10-25 1:40 UTC (permalink / raw) To: linux-kselftest Cc: shuah, linux-kernel, Li Zhijian, Pablo Neira Ayuso, Jozsef Kadlecsik, David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni, netfilter-devel, coreteam, netdev Compiled binary files should be added to .gitignore 'git status' complains: Untracked files: (use "git add <file>..." to include in what will be committed) net/netfilter/conntrack_reverse_clash Cc: Pablo Neira Ayuso <pablo@netfilter.org> Cc: Jozsef Kadlecsik <kadlec@netfilter.org> Cc: "David S. Miller" <davem@davemloft.net> Cc: Eric Dumazet <edumazet@google.com> Cc: Jakub Kicinski <kuba@kernel.org> Cc: Paolo Abeni <pabeni@redhat.com> Cc: Shuah Khan <shuah@kernel.org> Signed-off-by: Li Zhijian <lizhijian@fujitsu.com> --- Cc: netfilter-devel@vger.kernel.org Cc: coreteam@netfilter.org Cc: netdev@vger.kernel.org --- Hello, Cover letter is here. This patch set aims to make 'git status' clear after 'make' and 'make run_tests' for kselftests. --- V2: split as a separate patch from a small one [0] [0] https://lore.kernel.org/linux-kselftest/20241015010817.453539-1-lizhijian@fujitsu.com/ --- tools/testing/selftests/net/netfilter/.gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/testing/selftests/net/netfilter/.gitignore b/tools/testing/selftests/net/netfilter/.gitignore index 0a64d6d0e29a..eef8d5784e94 100644 --- a/tools/testing/selftests/net/netfilter/.gitignore +++ b/tools/testing/selftests/net/netfilter/.gitignore @@ -4,3 +4,4 @@ connect_close conntrack_dump_flush sctp_collision nf_queue +conntrack_reverse_clash -- 2.44.0 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH for-next 4/7] selftests/net: Add missing gitignore file 2024-10-25 1:40 ` [PATCH for-next 4/7] selftests/net: Add missing gitignore file Li Zhijian @ 2024-10-29 23:33 ` Jakub Kicinski 0 siblings, 0 replies; 6+ messages in thread From: Jakub Kicinski @ 2024-10-29 23:33 UTC (permalink / raw) To: Li Zhijian Cc: linux-kselftest, shuah, linux-kernel, Pablo Neira Ayuso, Jozsef Kadlecsik, David S. Miller, Eric Dumazet, Paolo Abeni, netfilter-devel, coreteam, netdev On Fri, 25 Oct 2024 09:40:07 +0800 Li Zhijian wrote: > diff --git a/tools/testing/selftests/net/netfilter/.gitignore b/tools/testing/selftests/net/netfilter/.gitignore > index 0a64d6d0e29a..eef8d5784e94 100644 > --- a/tools/testing/selftests/net/netfilter/.gitignore > +++ b/tools/testing/selftests/net/netfilter/.gitignore > @@ -4,3 +4,4 @@ connect_close > conntrack_dump_flush > sctp_collision > nf_queue > +conntrack_reverse_clash This gitignore file appears to be sorted, please move the new entry up into the right place and repost as a standalone patch (not part of a series) so that its easier to netfilter maintainers to pick it up. ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH for-next 7/7] selftests/net: Fix ./ns-XXXXXX not cleanup [not found] <20241025014010.6533-1-lizhijian@fujitsu.com> 2024-10-25 1:40 ` [PATCH for-next 4/7] selftests/net: Add missing gitignore file Li Zhijian @ 2024-10-25 1:40 ` Li Zhijian 2024-10-29 23:43 ` Jakub Kicinski 1 sibling, 1 reply; 6+ messages in thread From: Li Zhijian @ 2024-10-25 1:40 UTC (permalink / raw) To: linux-kselftest Cc: shuah, linux-kernel, Li Zhijian, David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni, netdev ``` readonly STATS="$(mktemp -p /tmp ns-XXXXXX)" readonly BASE=`basename $STATS` ``` It could be a mistake to write to $BASE rather than $STATS, where $STATS is used to save the NSTAT_HISTORY and it will be cleaned up before exit. Cc: "David S. Miller" <davem@davemloft.net> Cc: Eric Dumazet <edumazet@google.com> Cc: Jakub Kicinski <kuba@kernel.org> Cc: Paolo Abeni <pabeni@redhat.com> Signed-off-by: Li Zhijian <lizhijian@fujitsu.com> --- Cc: netdev@vger.kernel.org --- Hello, Cover letter is here. This patch set aims to make 'git status' clear after 'make' and 'make run_tests' for kselftests. --- V2: nothing change --- tools/testing/selftests/net/veth.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/testing/selftests/net/veth.sh b/tools/testing/selftests/net/veth.sh index 4f1edbafb946..457312ef135a 100755 --- a/tools/testing/selftests/net/veth.sh +++ b/tools/testing/selftests/net/veth.sh @@ -46,8 +46,8 @@ create_ns() { ip -n $BASE$ns addr add dev veth$ns $BM_NET_V4$ns/24 ip -n $BASE$ns addr add dev veth$ns $BM_NET_V6$ns/64 nodad done - echo "#kernel" > $BASE - chmod go-rw $BASE + echo "#kernel" > $STATS + chmod go-rw $STATS } __chk_flag() { -- 2.44.0 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH for-next 7/7] selftests/net: Fix ./ns-XXXXXX not cleanup 2024-10-25 1:40 ` [PATCH for-next 7/7] selftests/net: Fix ./ns-XXXXXX not cleanup Li Zhijian @ 2024-10-29 23:43 ` Jakub Kicinski 2024-10-29 23:43 ` Jakub Kicinski 2024-10-30 0:54 ` Zhijian Li (Fujitsu) 0 siblings, 2 replies; 6+ messages in thread From: Jakub Kicinski @ 2024-10-29 23:43 UTC (permalink / raw) To: Li Zhijian Cc: linux-kselftest, shuah, linux-kernel, David S. Miller, Eric Dumazet, Paolo Abeni, netdev On Fri, 25 Oct 2024 09:40:10 +0800 Li Zhijian wrote: > ``` > readonly STATS="$(mktemp -p /tmp ns-XXXXXX)" > readonly BASE=`basename $STATS` > ``` > It could be a mistake to write to $BASE rather than $STATS, where $STATS > is used to save the NSTAT_HISTORY and it will be cleaned up before exit. Agreed, although since we've been creating the wrong file this whole time and everything worked -- should we just just delete those two lines completely? Similarly to patch 6 - please repost as a standalone patch so that our CI will test it. If you only CC a mailing list on subset of patches they are likely to be ignored by automation.. -- pw-bot: cr ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH for-next 7/7] selftests/net: Fix ./ns-XXXXXX not cleanup 2024-10-29 23:43 ` Jakub Kicinski @ 2024-10-29 23:43 ` Jakub Kicinski 2024-10-30 0:54 ` Zhijian Li (Fujitsu) 1 sibling, 0 replies; 6+ messages in thread From: Jakub Kicinski @ 2024-10-29 23:43 UTC (permalink / raw) To: Li Zhijian Cc: linux-kselftest, shuah, linux-kernel, David S. Miller, Eric Dumazet, Paolo Abeni, netdev On Tue, 29 Oct 2024 16:43:06 -0700 Jakub Kicinski wrote: > Similarly to patch 6 I meant patch 4, not patch 6 ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH for-next 7/7] selftests/net: Fix ./ns-XXXXXX not cleanup 2024-10-29 23:43 ` Jakub Kicinski 2024-10-29 23:43 ` Jakub Kicinski @ 2024-10-30 0:54 ` Zhijian Li (Fujitsu) 1 sibling, 0 replies; 6+ messages in thread From: Zhijian Li (Fujitsu) @ 2024-10-30 0:54 UTC (permalink / raw) To: Jakub Kicinski Cc: linux-kselftest@vger.kernel.org, shuah@kernel.org, linux-kernel@vger.kernel.org, David S. Miller, Eric Dumazet, Paolo Abeni, netdev@vger.kernel.org On 30/10/2024 07:43, Jakub Kicinski wrote: > On Fri, 25 Oct 2024 09:40:10 +0800 Li Zhijian wrote: >> ``` >> readonly STATS="$(mktemp -p /tmp ns-XXXXXX)" >> readonly BASE=`basename $STATS` >> ``` >> It could be a mistake to write to $BASE rather than $STATS, where $STATS >> is used to save the NSTAT_HISTORY and it will be cleaned up before exit. > > Agreed, although since we've been creating the wrong file this whole > time and everything worked >-- should we just just delete those two lines completely? Yes, it also works. > > Similarly to patch 6 - please repost as a standalone patch so that our > CI will test it. If you only CC a mailing list on subset of patches > they are likely to be ignored by automation.. Got it Thanks Zhijian ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-10-30 0:54 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20241025014010.6533-1-lizhijian@fujitsu.com>
2024-10-25 1:40 ` [PATCH for-next 4/7] selftests/net: Add missing gitignore file Li Zhijian
2024-10-29 23:33 ` Jakub Kicinski
2024-10-25 1:40 ` [PATCH for-next 7/7] selftests/net: Fix ./ns-XXXXXX not cleanup Li Zhijian
2024-10-29 23:43 ` Jakub Kicinski
2024-10-29 23:43 ` Jakub Kicinski
2024-10-30 0:54 ` Zhijian Li (Fujitsu)
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).