From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3F4E311CAF; Wed, 30 Oct 2024 00:29:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730248162; cv=none; b=CybzGzjiHBTLbXBDTpMEamzgK922tlzG+AHZ6KzchLO6KEvUOCvaKFGr23TGG7NX9ggJhdzhz4w3dKonD8USVG3fI/6pSQsuTU9Ocklh93ewzX3JeVsdmyy6yMju6EJk284/4cCsKT4wpFWShh0bx3XROedPOCqLZG9YuL9FUhE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730248162; c=relaxed/simple; bh=1pq/pDL/Y5H4W0YB257TIBJQI2fBtFz8VjZsvNmGvNk=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=WfMXEzecPpQnKImma3jLs6ceu3s0P/zr4osL48qAHKvqu1yXsikZhtm7h/YhpmgeWS/vz6pHw/W7BNVEEyLcGedvvs6ttyTPuQP2o5DpP5T0g8raqM3/e3eq1Ndt88VnqZN+fXAtNgp7A7uHXBQ/KNO8XKcd3P8jxs0xVoc6Oc0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=bZ3W39tZ; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="bZ3W39tZ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8F0DDC4CEE3; Wed, 30 Oct 2024 00:29:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1730248162; bh=1pq/pDL/Y5H4W0YB257TIBJQI2fBtFz8VjZsvNmGvNk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=bZ3W39tZViMdn/Nwn5Stpkgu235jsEKj6+KJv0jqX2e7Go6bkxM2RJIAvJYL3NK2P FwuU/W+Opt6iuyH/HIivOwVi5dN8rFZp6x2o+lpI+aPY2/QMaDkrz5V6aVipI8NKkV qnnVj7dvucq23Kdd+mpPh3nKFQFdlee00ZYc/0Wj1MPeMV+gQNyyQ/83TrvBLqRCNi 6pbBUvcTTAmILsQw+X44VemMUtgaHhROMQsHzmCOIEaoH+UF/4EGaaXPZ/lEzqtQO/ qOf66AZRteSWPAnmrKVvsSzPVLw2NkXnES/aUIIv2mZVNgv3/jYaPiOLvBvv9x4LIG xV6UbHZOBmiow== Date: Tue, 29 Oct 2024 17:29:20 -0700 From: Jakub Kicinski To: Caleb Sander Mateos Cc: Saeed Mahameed , Leon Romanovsky , Tariq Toukan , Andrew Lunn , "David S. Miller" , Eric Dumazet , Paolo Abeni , netdev@vger.kernel.org, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mlx5: simplify EQ interrupt polling logic Message-ID: <20241029172920.21cee16a@kernel.org> In-Reply-To: <20241023205113.255866-1-csander@purestorage.com> References: <20241023205113.255866-1-csander@purestorage.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 23 Oct 2024 14:51:12 -0600 Caleb Sander Mateos wrote: > Use a while loop in mlx5_eq_comp_int() and mlx5_eq_async_int() to > clarify the EQE polling logic. This consolidates the next_eqe_sw() calls > for the first and subequent iterations. It also avoids a goto. Turn the > num_eqes < MLX5_EQ_POLLING_BUDGET check into a break condition. Applied, thanks!