From: Vladimir Oltean <olteanv@gmail.com>
To: Furong Xu <0x1207@gmail.com>
Cc: netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Andrew Lunn <andrew@lunn.ch>,
Simon Horman <horms@kernel.org>,
andrew+netdev@lunn.ch,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Jose Abreu <joabreu@synopsys.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
xfr@outlook.com
Subject: Re: [PATCH net-next v6 3/6] net: stmmac: Refactor FPE functions to generic version
Date: Wed, 30 Oct 2024 14:10:46 +0200 [thread overview]
Message-ID: <20241030121046.ojd7zx3jbyg4l4iq@skbuf> (raw)
In-Reply-To: <cc87e0e02610a5ebfb0079716061f57fb9678dfc.1730263957.git.0x1207@gmail.com> <cc87e0e02610a5ebfb0079716061f57fb9678dfc.1730263957.git.0x1207@gmail.com>
On Wed, Oct 30, 2024 at 01:36:12PM +0800, Furong Xu wrote:
> +bool stmmac_fpe_supported(struct stmmac_priv *priv)
> +{
> + return (priv->dma_cap.fpesel && priv->fpe_cfg.reg);
> +}
Should we also add the condition that stmmac_ops :: fpe_map_preemption_class()
is implemented? For future implementers to figure out what they need.
next prev parent reply other threads:[~2024-10-30 12:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-30 5:36 [PATCH net-next v6 0/6] net: stmmac: Refactor FPE as a separate module Furong Xu
2024-10-30 5:36 ` [PATCH net-next v6 1/6] net: stmmac: Introduce separate files for FPE implementation Furong Xu
2024-10-30 5:36 ` [PATCH net-next v6 2/6] net: stmmac: Rework macro definitions for gmac4 and xgmac Furong Xu
2024-10-30 5:36 ` [PATCH net-next v6 3/6] net: stmmac: Refactor FPE functions to generic version Furong Xu
2024-10-30 11:47 ` Vladimir Oltean
2024-10-30 12:10 ` Vladimir Oltean [this message]
2024-10-30 5:36 ` [PATCH net-next v6 4/6] net: stmmac: xgmac: Rename XGMAC_RQ to XGMAC_FPRQ Furong Xu
2024-10-30 5:36 ` [PATCH net-next v6 5/6] net: stmmac: xgmac: Complete FPE support Furong Xu
2024-10-30 11:51 ` Vladimir Oltean
2024-10-30 5:36 ` [PATCH net-next v6 6/6] net: stmmac: xgmac: Enable FPE for tc-mqprio/tc-taprio Furong Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241030121046.ojd7zx3jbyg4l4iq@skbuf \
--to=olteanv@gmail.com \
--cc=0x1207@gmail.com \
--cc=alexandre.torgue@foss.st.com \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=joabreu@synopsys.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=xfr@outlook.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox