From: Jakub Kicinski <kuba@kernel.org>
To: Breno Leitao <leitao@debian.org>
Cc: Jonathan Corbet <corbet@lwn.net>,
Akinobu Mita <akinobu.mita@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
kernel-team@meta.com, Thomas Huth <thuth@redhat.com>,
"Paul E. McKenney" <paulmck@kernel.org>,
"Borislav Petkov (AMD)" <bp@alien8.de>,
Steven Rostedt <rostedt@goodmis.org>,
Xiongwei Song <xiongwei.song@windriver.com>,
Mina Almasry <almasrymina@google.com>,
Kuniyuki Iwashima <kuniyu@amazon.com>,
Alexander Lobakin <aleksander.lobakin@intel.com>,
Oleksij Rempel <o.rempel@pengutronix.de>,
"open list:DOCUMENTATION" <linux-doc@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
"open list:NETWORKING [GENERAL]" <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next v4] net: Implement fault injection forcing skb reallocation
Date: Thu, 31 Oct 2024 17:04:28 -0700 [thread overview]
Message-ID: <20241031170428.27c1f26a@kernel.org> (raw)
In-Reply-To: <20241031-hallowed-bizarre-curassow-ea16cc@leitao>
On Thu, 31 Oct 2024 02:41:18 -0700 Breno Leitao wrote:
> > Should we mention here that KASAN or some such is needed to catch
> > the bugs? Chances are the resulting UAF will not crash and go unnoticed
> > without KASAN.
>
> What about adding something like this in the fail_skb_realloc section in
> the fault-injection.rst file:
SG
> > the buffer needs to be null terminated, like:
> >
> > skb_realloc.devname[IFNAMSIZ - 1] = '\0';
> >
> > no?
>
> Yes, but isn't it what the next line do, with strim()?
I could be wrong, but looks like first thing strim does is call strlen()
next prev parent reply other threads:[~2024-11-01 0:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-23 11:38 [PATCH net-next v4] net: Implement fault injection forcing skb reallocation Breno Leitao
2024-10-24 10:01 ` Bagas Sanjaya
2024-10-31 0:31 ` Jakub Kicinski
2024-10-31 9:41 ` Breno Leitao
2024-11-01 0:04 ` Jakub Kicinski [this message]
2024-11-01 9:55 ` Breno Leitao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241031170428.27c1f26a@kernel.org \
--to=kuba@kernel.org \
--cc=akinobu.mita@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=aleksander.lobakin@intel.com \
--cc=almasrymina@google.com \
--cc=bp@alien8.de \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kernel-team@meta.com \
--cc=kuniyu@amazon.com \
--cc=leitao@debian.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=pabeni@redhat.com \
--cc=paulmck@kernel.org \
--cc=rostedt@goodmis.org \
--cc=thuth@redhat.com \
--cc=xiongwei.song@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).