From: Jakub Kicinski <kuba@kernel.org>
To: Tariq Toukan <tariqt@nvidia.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>,
Eric Dumazet <edumazet@google.com>,
"Andrew Lunn" <andrew+netdev@lunn.ch>,
Jay Vosburgh <jv@jvosburgh.net>,
"Andy Gospodarek" <andy@greyhouse.net>, <netdev@vger.kernel.org>,
Saeed Mahameed <saeedm@nvidia.com>, Gal Pressman <gal@nvidia.com>,
Leon Romanovsky <leonro@nvidia.com>,
Jianbo Liu <jianbol@nvidia.com>,
Boris Pismenny <borisp@nvidia.com>
Subject: Re: [PATCH net-next] bonding: add ESP offload features when slaves support
Date: Thu, 31 Oct 2024 17:48:44 -0700 [thread overview]
Message-ID: <20241031174844.06a5b110@kernel.org> (raw)
In-Reply-To: <20241024163112.298865-1-tariqt@nvidia.com>
On Thu, 24 Oct 2024 19:31:12 +0300 Tariq Toukan wrote:
> +#ifdef CONFIG_XFRM_OFFLOAD
> + if (gso_partial_features & NETIF_F_GSO_ESP)
> + bond_dev->gso_partial_features |= NETIF_F_GSO_ESP;
> + else
> + bond_dev->gso_partial_features &= ~NETIF_F_GSO_ESP;
> +#endif /* CONFIG_XFRM_OFFLOAD */
Hiding the block under ifdef is unnecessary.
If you worry about the no-lower devs case - add IS_ENABLED()
to the if condition. The local variable doesn't have to be under
ifdef either (making it more rev xmas tree compatible)
--
pw-bot: cr
next prev parent reply other threads:[~2024-11-01 0:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-24 16:31 [PATCH net-next] bonding: add ESP offload features when slaves support Tariq Toukan
2024-11-01 0:48 ` Jakub Kicinski [this message]
2024-11-01 2:03 ` Jianbo Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241031174844.06a5b110@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=andy@greyhouse.net \
--cc=borisp@nvidia.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gal@nvidia.com \
--cc=jianbol@nvidia.com \
--cc=jv@jvosburgh.net \
--cc=leonro@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=saeedm@nvidia.com \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).