From: Jakub Kicinski <kuba@kernel.org>
To: Jijie Shao <shaojijie@huawei.com>
Cc: <davem@davemloft.net>, <edumazet@google.com>, <pabeni@redhat.com>,
<andrew+netdev@lunn.ch>, <horms@kernel.org>,
<shenjian15@huawei.com>, <wangpeiyang1@huawei.com>,
<liuyonglong@huawei.com>, <chenhao418@huawei.com>,
<sudongming1@huawei.com>, <xujunsheng@huawei.com>,
<shiyongbang@huawei.com>, <libaihan@huawei.com>,
<jonathan.cameron@huawei.com>,
<shameerali.kolothum.thodi@huawei.com>, <salil.mehta@huawei.com>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V2 net-next 1/8] net: hibmcge: Add dump statistics supported in this module
Date: Thu, 31 Oct 2024 18:45:27 -0700 [thread overview]
Message-ID: <20241031184527.1d6afe84@kernel.org> (raw)
In-Reply-To: <20241026115740.633503-2-shaojijie@huawei.com>
On Sat, 26 Oct 2024 19:57:33 +0800 Jijie Shao wrote:
> + HBG_STATS_REG_I(rx_framesize_64, HBG_REG_RX_PKTS_64OCTETS_ADDR),
> + HBG_STATS_REG_I(rx_framesize_65_127,
> + HBG_REG_RX_PKTS_65TO127OCTETS_ADDR),
> + HBG_STATS_REG_I(rx_framesize_128_255,
> + HBG_REG_RX_PKTS_128TO255OCTETS_ADDR),
> + HBG_STATS_REG_I(rx_framesize_256_511,
> + HBG_REG_RX_PKTS_256TO511OCTETS_ADDR),
> + HBG_STATS_REG_I(rx_framesize_512_1023,
> + HBG_REG_RX_PKTS_512TO1023OCTETS_ADDR),
> + HBG_STATS_REG_I(rx_framesize_1024_1518,
> + HBG_REG_RX_PKTS_1024TO1518OCTETS_ADDR),
> + HBG_STATS_REG_I(rx_framesize_bt_1518,
> + HBG_REG_RX_PKTS_1519TOMAXOCTETS_ADDR),
> + HBG_STATS_REG_I(rx_fcs_error_cnt, HBG_REG_RX_FCS_ERRORS_ADDR),
> + HBG_STATS_REG_I(rx_data_error_cnt, HBG_REG_RX_DATA_ERR_ADDR),
> + HBG_STATS_REG_I(rx_align_error_cnt, HBG_REG_RX_ALIGN_ERRORS_ADDR),
> + HBG_STATS_REG_I(rx_frame_long_err_cnt, HBG_REG_RX_LONG_ERRORS_ADDR),
Please do not dump in ethtool statistics which can be accessed via
standard APIs like ethtool -I, queue_stats or rtnl_stat.
https://docs.kernel.org/next/networking/statistics.html
next prev parent reply other threads:[~2024-11-01 1:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-26 11:57 [PATCH V2 net-next 0/8] Support some features for the HIBMCGE driver Jijie Shao
2024-10-26 11:57 ` [PATCH V2 net-next 1/8] net: hibmcge: Add dump statistics supported in this module Jijie Shao
2024-11-01 1:45 ` Jakub Kicinski [this message]
2024-11-01 6:08 ` Jijie Shao
2024-10-26 11:57 ` [PATCH V2 net-next 2/8] net: hibmcge: Add debugfs " Jijie Shao
2024-10-26 11:57 ` [PATCH V2 net-next 3/8] net: hibmcge: Add irq_info file to debugfs Jijie Shao
2024-10-26 11:57 ` [PATCH V2 net-next 4/8] net: hibmcge: Add unicast frame filter supported in this module Jijie Shao
2024-10-26 11:57 ` [PATCH V2 net-next 5/8] net: hibmcge: Add register dump " Jijie Shao
2024-10-26 11:57 ` [PATCH V2 net-next 6/8] net: hibmcge: Add pauseparam " Jijie Shao
2024-10-26 11:57 ` [PATCH V2 net-next 7/8] net: hibmcge: Add reset " Jijie Shao
2024-10-26 11:57 ` [PATCH V2 net-next 8/8] net: hibmcge: Add nway_reset " Jijie Shao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241031184527.1d6afe84@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=chenhao418@huawei.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jonathan.cameron@huawei.com \
--cc=libaihan@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=liuyonglong@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=salil.mehta@huawei.com \
--cc=shameerali.kolothum.thodi@huawei.com \
--cc=shaojijie@huawei.com \
--cc=shenjian15@huawei.com \
--cc=shiyongbang@huawei.com \
--cc=sudongming1@huawei.com \
--cc=wangpeiyang1@huawei.com \
--cc=xujunsheng@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).