* RE: [PATCH net] dt-bindings: net: xlnx,axi-ethernet: Correct phy-mode property value
2024-10-28 9:12 [PATCH net] dt-bindings: net: xlnx,axi-ethernet: Correct phy-mode property value Suraj Gupta
@ 2024-10-30 6:12 ` Pandey, Radhey Shyam
2024-10-30 13:35 ` Andrew Lunn
2024-11-01 1:53 ` Jakub Kicinski
2024-11-02 2:20 ` patchwork-bot+netdevbpf
2 siblings, 1 reply; 7+ messages in thread
From: Pandey, Radhey Shyam @ 2024-10-30 6:12 UTC (permalink / raw)
To: Gupta, Suraj, andrew+netdev@lunn.ch, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: git (AMD-Xilinx), Katakam, Harini
> -----Original Message-----
> From: Suraj Gupta <suraj.gupta2@amd.com>
> Sent: Monday, October 28, 2024 2:42 PM
> To: Pandey, Radhey Shyam <radhey.shyam.pandey@amd.com>;
> andrew+netdev@lunn.ch; davem@davemloft.net; edumazet@google.com;
> kuba@kernel.org; pabeni@redhat.com; robh@kernel.org; krzk+dt@kernel.org;
> conor+dt@kernel.org; netdev@vger.kernel.org; devicetree@vger.kernel.org; linux-
> kernel@vger.kernel.org
> Cc: git (AMD-Xilinx) <git@amd.com>; Katakam, Harini <harini.katakam@amd.com>
> Subject: [PATCH net] dt-bindings: net: xlnx,axi-ethernet: Correct phy-mode property
> value
>
> Correct phy-mode property value to 1000base-x.
>
> Fixes: cbb1ca6d5f9a ("dt-bindings: net: xlnx,axi-ethernet: convert bindings document
> to yaml")
> Signed-off-by: Suraj Gupta <suraj.gupta2@amd.com>
Reviewed-by: Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>
Thanks!
> ---
> Documentation/devicetree/bindings/net/xlnx,axi-ethernet.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/net/xlnx,axi-ethernet.yaml
> b/Documentation/devicetree/bindings/net/xlnx,axi-ethernet.yaml
> index e95c21628281..fb02e579463c 100644
> --- a/Documentation/devicetree/bindings/net/xlnx,axi-ethernet.yaml
> +++ b/Documentation/devicetree/bindings/net/xlnx,axi-ethernet.yaml
> @@ -61,7 +61,7 @@ properties:
> - gmii
> - rgmii
> - sgmii
> - - 1000BaseX
> + - 1000base-x
>
> xlnx,phy-type:
> description:
> --
> 2.25.1
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH net] dt-bindings: net: xlnx,axi-ethernet: Correct phy-mode property value
2024-10-30 6:12 ` Pandey, Radhey Shyam
@ 2024-10-30 13:35 ` Andrew Lunn
0 siblings, 0 replies; 7+ messages in thread
From: Andrew Lunn @ 2024-10-30 13:35 UTC (permalink / raw)
To: Pandey, Radhey Shyam
Cc: Gupta, Suraj, andrew+netdev@lunn.ch, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, git (AMD-Xilinx), Katakam, Harini
On Wed, Oct 30, 2024 at 06:12:37AM +0000, Pandey, Radhey Shyam wrote:
> > -----Original Message-----
> > From: Suraj Gupta <suraj.gupta2@amd.com>
> > Sent: Monday, October 28, 2024 2:42 PM
> > To: Pandey, Radhey Shyam <radhey.shyam.pandey@amd.com>;
> > andrew+netdev@lunn.ch; davem@davemloft.net; edumazet@google.com;
> > kuba@kernel.org; pabeni@redhat.com; robh@kernel.org; krzk+dt@kernel.org;
> > conor+dt@kernel.org; netdev@vger.kernel.org; devicetree@vger.kernel.org; linux-
> > kernel@vger.kernel.org
> > Cc: git (AMD-Xilinx) <git@amd.com>; Katakam, Harini <harini.katakam@amd.com>
> > Subject: [PATCH net] dt-bindings: net: xlnx,axi-ethernet: Correct phy-mode property
> > value
> >
> > Correct phy-mode property value to 1000base-x.
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH net] dt-bindings: net: xlnx,axi-ethernet: Correct phy-mode property value
2024-10-28 9:12 [PATCH net] dt-bindings: net: xlnx,axi-ethernet: Correct phy-mode property value Suraj Gupta
2024-10-30 6:12 ` Pandey, Radhey Shyam
@ 2024-11-01 1:53 ` Jakub Kicinski
2024-11-01 17:14 ` Conor Dooley
2024-11-02 2:20 ` patchwork-bot+netdevbpf
2 siblings, 1 reply; 7+ messages in thread
From: Jakub Kicinski @ 2024-11-01 1:53 UTC (permalink / raw)
To: Suraj Gupta, robh, krzk+dt, conor+dt
Cc: radhey.shyam.pandey, andrew+netdev, davem, edumazet, pabeni,
netdev, devicetree, linux-kernel, git, harini.katakam
On Mon, 28 Oct 2024 14:42:14 +0530 Suraj Gupta wrote:
> Correct phy-mode property value to 1000base-x.
>
> Fixes: cbb1ca6d5f9a ("dt-bindings: net: xlnx,axi-ethernet: convert bindings document to yaml")
> Signed-off-by: Suraj Gupta <suraj.gupta2@amd.com>
> ---
> Documentation/devicetree/bindings/net/xlnx,axi-ethernet.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/net/xlnx,axi-ethernet.yaml b/Documentation/devicetree/bindings/net/xlnx,axi-ethernet.yaml
> index e95c21628281..fb02e579463c 100644
> --- a/Documentation/devicetree/bindings/net/xlnx,axi-ethernet.yaml
> +++ b/Documentation/devicetree/bindings/net/xlnx,axi-ethernet.yaml
> @@ -61,7 +61,7 @@ properties:
> - gmii
> - rgmii
> - sgmii
> - - 1000BaseX
> + - 1000base-x
>
> xlnx,phy-type:
> description:
Can we get an ack from DT folks?
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH net] dt-bindings: net: xlnx,axi-ethernet: Correct phy-mode property value
2024-11-01 1:53 ` Jakub Kicinski
@ 2024-11-01 17:14 ` Conor Dooley
2024-11-01 17:34 ` Rob Herring
0 siblings, 1 reply; 7+ messages in thread
From: Conor Dooley @ 2024-11-01 17:14 UTC (permalink / raw)
To: Jakub Kicinski
Cc: Suraj Gupta, robh, krzk+dt, conor+dt, radhey.shyam.pandey,
andrew+netdev, davem, edumazet, pabeni, netdev, devicetree,
linux-kernel, git, harini.katakam
[-- Attachment #1: Type: text/plain, Size: 1268 bytes --]
On Thu, Oct 31, 2024 at 06:53:12PM -0700, Jakub Kicinski wrote:
> On Mon, 28 Oct 2024 14:42:14 +0530 Suraj Gupta wrote:
> > Correct phy-mode property value to 1000base-x.
> >
> > Fixes: cbb1ca6d5f9a ("dt-bindings: net: xlnx,axi-ethernet: convert bindings document to yaml")
> > Signed-off-by: Suraj Gupta <suraj.gupta2@amd.com>
> > ---
> > Documentation/devicetree/bindings/net/xlnx,axi-ethernet.yaml | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/net/xlnx,axi-ethernet.yaml b/Documentation/devicetree/bindings/net/xlnx,axi-ethernet.yaml
> > index e95c21628281..fb02e579463c 100644
> > --- a/Documentation/devicetree/bindings/net/xlnx,axi-ethernet.yaml
> > +++ b/Documentation/devicetree/bindings/net/xlnx,axi-ethernet.yaml
> > @@ -61,7 +61,7 @@ properties:
> > - gmii
> > - rgmii
> > - sgmii
> > - - 1000BaseX
> > + - 1000base-x
> >
> > xlnx,phy-type:
> > description:
>
> Can we get an ack from DT folks?
I dunno, the commit message gives no detail at all about the impact of
changing this, so I don't want to ack it. I *assume* that this is parsed
by common code and 1000BaseX is not understood by that common code,
but...
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH net] dt-bindings: net: xlnx,axi-ethernet: Correct phy-mode property value
2024-11-01 17:14 ` Conor Dooley
@ 2024-11-01 17:34 ` Rob Herring
0 siblings, 0 replies; 7+ messages in thread
From: Rob Herring @ 2024-11-01 17:34 UTC (permalink / raw)
To: Conor Dooley
Cc: Jakub Kicinski, Suraj Gupta, krzk+dt, conor+dt,
radhey.shyam.pandey, andrew+netdev, davem, edumazet, pabeni,
netdev, devicetree, linux-kernel, git, harini.katakam
On Fri, Nov 01, 2024 at 05:14:50PM +0000, Conor Dooley wrote:
> On Thu, Oct 31, 2024 at 06:53:12PM -0700, Jakub Kicinski wrote:
> > On Mon, 28 Oct 2024 14:42:14 +0530 Suraj Gupta wrote:
> > > Correct phy-mode property value to 1000base-x.
> > >
> > > Fixes: cbb1ca6d5f9a ("dt-bindings: net: xlnx,axi-ethernet: convert bindings document to yaml")
> > > Signed-off-by: Suraj Gupta <suraj.gupta2@amd.com>
> > > ---
> > > Documentation/devicetree/bindings/net/xlnx,axi-ethernet.yaml | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/Documentation/devicetree/bindings/net/xlnx,axi-ethernet.yaml b/Documentation/devicetree/bindings/net/xlnx,axi-ethernet.yaml
> > > index e95c21628281..fb02e579463c 100644
> > > --- a/Documentation/devicetree/bindings/net/xlnx,axi-ethernet.yaml
> > > +++ b/Documentation/devicetree/bindings/net/xlnx,axi-ethernet.yaml
> > > @@ -61,7 +61,7 @@ properties:
> > > - gmii
> > > - rgmii
> > > - sgmii
> > > - - 1000BaseX
> > > + - 1000base-x
> > >
> > > xlnx,phy-type:
> > > description:
> >
> > Can we get an ack from DT folks?
>
> I dunno, the commit message gives no detail at all about the impact of
> changing this, so I don't want to ack it. I *assume* that this is parsed
> by common code and 1000BaseX is not understood by that common code,
> but...
We're the ones defining the names in ethernet-controller.yaml. It should
also have failed validation if used because the list here must be a
subset of that list. So nothing to do with whatever the kernel does.
Acked-by: Rob Herring (Arm) <robh@kernel.org>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH net] dt-bindings: net: xlnx,axi-ethernet: Correct phy-mode property value
2024-10-28 9:12 [PATCH net] dt-bindings: net: xlnx,axi-ethernet: Correct phy-mode property value Suraj Gupta
2024-10-30 6:12 ` Pandey, Radhey Shyam
2024-11-01 1:53 ` Jakub Kicinski
@ 2024-11-02 2:20 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 7+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-11-02 2:20 UTC (permalink / raw)
To: Suraj Gupta
Cc: radhey.shyam.pandey, andrew+netdev, davem, edumazet, kuba, pabeni,
robh, krzk+dt, conor+dt, netdev, devicetree, linux-kernel, git,
harini.katakam
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Mon, 28 Oct 2024 14:42:14 +0530 you wrote:
> Correct phy-mode property value to 1000base-x.
>
> Fixes: cbb1ca6d5f9a ("dt-bindings: net: xlnx,axi-ethernet: convert bindings document to yaml")
> Signed-off-by: Suraj Gupta <suraj.gupta2@amd.com>
> ---
> Documentation/devicetree/bindings/net/xlnx,axi-ethernet.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Here is the summary with links:
- [net] dt-bindings: net: xlnx,axi-ethernet: Correct phy-mode property value
https://git.kernel.org/netdev/net/c/b2183187c5fd
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 7+ messages in thread