From: Conor Dooley <conor@kernel.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Suraj Gupta <suraj.gupta2@amd.com>,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
radhey.shyam.pandey@amd.com, andrew+netdev@lunn.ch,
davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, git@amd.com,
harini.katakam@amd.com
Subject: Re: [PATCH net] dt-bindings: net: xlnx,axi-ethernet: Correct phy-mode property value
Date: Fri, 1 Nov 2024 17:14:50 +0000 [thread overview]
Message-ID: <20241101-left-handshake-7efc5a202311@spud> (raw)
In-Reply-To: <20241031185312.65bc62dc@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 1268 bytes --]
On Thu, Oct 31, 2024 at 06:53:12PM -0700, Jakub Kicinski wrote:
> On Mon, 28 Oct 2024 14:42:14 +0530 Suraj Gupta wrote:
> > Correct phy-mode property value to 1000base-x.
> >
> > Fixes: cbb1ca6d5f9a ("dt-bindings: net: xlnx,axi-ethernet: convert bindings document to yaml")
> > Signed-off-by: Suraj Gupta <suraj.gupta2@amd.com>
> > ---
> > Documentation/devicetree/bindings/net/xlnx,axi-ethernet.yaml | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/net/xlnx,axi-ethernet.yaml b/Documentation/devicetree/bindings/net/xlnx,axi-ethernet.yaml
> > index e95c21628281..fb02e579463c 100644
> > --- a/Documentation/devicetree/bindings/net/xlnx,axi-ethernet.yaml
> > +++ b/Documentation/devicetree/bindings/net/xlnx,axi-ethernet.yaml
> > @@ -61,7 +61,7 @@ properties:
> > - gmii
> > - rgmii
> > - sgmii
> > - - 1000BaseX
> > + - 1000base-x
> >
> > xlnx,phy-type:
> > description:
>
> Can we get an ack from DT folks?
I dunno, the commit message gives no detail at all about the impact of
changing this, so I don't want to ack it. I *assume* that this is parsed
by common code and 1000BaseX is not understood by that common code,
but...
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2024-11-01 17:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-28 9:12 [PATCH net] dt-bindings: net: xlnx,axi-ethernet: Correct phy-mode property value Suraj Gupta
2024-10-30 6:12 ` Pandey, Radhey Shyam
2024-10-30 13:35 ` Andrew Lunn
2024-11-01 1:53 ` Jakub Kicinski
2024-11-01 17:14 ` Conor Dooley [this message]
2024-11-01 17:34 ` Rob Herring
2024-11-02 2:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241101-left-handshake-7efc5a202311@spud \
--to=conor@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=git@amd.com \
--cc=harini.katakam@amd.com \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=radhey.shyam.pandey@amd.com \
--cc=robh@kernel.org \
--cc=suraj.gupta2@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).