From: Vladimir Oltean <vladimir.oltean@nxp.com>
To: Wei Fang <wei.fang@nxp.com>
Cc: "davem@davemloft.net" <davem@davemloft.net>,
"edumazet@google.com" <edumazet@google.com>,
"kuba@kernel.org" <kuba@kernel.org>,
"pabeni@redhat.com" <pabeni@redhat.com>,
"andrew+netdev@lunn.ch" <andrew+netdev@lunn.ch>,
Claudiu Manoil <claudiu.manoil@nxp.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"imx@lists.linux.dev" <imx@lists.linux.dev>
Subject: Re: [PATCH net] net: enetc: prevent VF from configuring preemptiable TCs
Date: Fri, 1 Nov 2024 13:55:19 +0200 [thread overview]
Message-ID: <20241101115519.2a6ce6daqrzmhcfh@skbuf> (raw)
In-Reply-To: <PAXPR04MB85104B9FCD3D74743E9B261488552@PAXPR04MB8510.eurprd04.prod.outlook.com>
On Thu, Oct 31, 2024 at 05:46:47AM +0200, Wei Fang wrote:
> > > Actually please do this instead:
> > >
> > > if (!(si->hw_features & ENETC_SI_F_QBU))
> > >
>
> Actually, VFs of eno0 have ENETC_SI_F_QBU bit set. So we should use the
> following check instead.
>
> if (!enetc_si_is_pf(si) || !(si->hw_features & ENETC_SI_F_QBU))
>
> Or we only set ENETC_SI_F_QBU bit for PF in enetc_get_si_caps() if the PF
> supports 802.1 Qbu.
This one is weird. I don't know why the ENETC would push a capability in
the SI port capability register 0 for the VSI, if the VSI doesn't have
access to the port registers in the first place. Let me ask internally,
so we could figure out what's the best thing to do.
next prev parent reply other threads:[~2024-11-01 11:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-30 8:21 [PATCH net] net: enetc: prevent VF from configuring preemptiable TCs Wei Fang
2024-10-30 15:15 ` Vladimir Oltean
2024-10-31 1:33 ` Wei Fang
2024-10-31 3:46 ` Wei Fang
2024-11-01 11:55 ` Vladimir Oltean [this message]
2024-11-01 14:02 ` Vladimir Oltean
2024-11-04 1:45 ` Wei Fang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241101115519.2a6ce6daqrzmhcfh@skbuf \
--to=vladimir.oltean@nxp.com \
--cc=andrew+netdev@lunn.ch \
--cc=claudiu.manoil@nxp.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=imx@lists.linux.dev \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=wei.fang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox