From: Jakub Kicinski <kuba@kernel.org>
To: Mina Almasry <almasrymina@google.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-kselftest@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
Jesper Dangaard Brouer <hawk@kernel.org>,
Ilias Apalodimas <ilias.apalodimas@linaro.org>,
Shuah Khan <shuah@kernel.org>
Subject: Re: [PATCH net-next v1 0/7] devmem TCP fixes
Date: Fri, 1 Nov 2024 19:27:39 -0700 [thread overview]
Message-ID: <20241101192739.6caece56@kernel.org> (raw)
In-Reply-To: <CAHS8izO-UhDfctAsjpdipRV=WyCvUAu9VnAes0mBe2wSvV3_9g@mail.gmail.com>
On Fri, 1 Nov 2024 06:14:14 -0700 Mina Almasry wrote:
> But what is the 'missing input validation'? Do you mean the input
> validation for the SO_DEVMEM_DONTNEED API? That should be handled in
> the patch "net: fix SO_DEVMEM_DONTNEED looping too long" in this
> series, unless I missed something.
I guess it's borderline but to me it feels like net material.
It changes the user visible behavior. Someone can write their
code to free 2k tokens on 6.12 and it will break on 6.13.
I don't feel strongly but the way the series ended up getting
split I figured maybe it was also your intuition. If you do
follow the net path -- please move the refactor out to the net-next
series.
next prev parent reply other threads:[~2024-11-02 2:27 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-29 20:55 [PATCH net-next v1 0/7] devmem TCP fixes Mina Almasry
2024-10-29 20:55 ` [PATCH net-next v1 6/7] net: fix SO_DEVMEM_DONTNEED looping too long Mina Almasry
2024-10-30 14:33 ` Stanislav Fomichev
2024-10-30 14:46 ` Mina Almasry
2024-10-30 15:06 ` Stanislav Fomichev
2024-11-05 21:28 ` Mina Almasry
2024-11-05 21:46 ` Stanislav Fomichev
2024-11-05 23:43 ` Mina Almasry
2024-11-06 0:13 ` Stanislav Fomichev
2024-10-29 20:55 ` [PATCH net-next v1 7/7] ncdevmem: add test for too many token_count Mina Almasry
2024-11-01 2:41 ` [PATCH net-next v1 0/7] devmem TCP fixes Jakub Kicinski
2024-11-01 13:14 ` Mina Almasry
2024-11-02 2:27 ` Jakub Kicinski [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-10-29 20:45 Mina Almasry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241101192739.6caece56@kernel.org \
--to=kuba@kernel.org \
--cc=almasrymina@google.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=horms@kernel.org \
--cc=ilias.apalodimas@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).