* [PATCH] net: ena: Remove deadcode
@ 2024-11-02 21:59 linux
2024-11-02 22:02 ` Dr. David Alan Gilbert
0 siblings, 1 reply; 2+ messages in thread
From: linux @ 2024-11-02 21:59 UTC (permalink / raw)
To: shayagr, akiyano, darinzon, ndagan, saeedb, andrew+netdev, davem,
edumazet, kuba, pabeni
Cc: netdev, linux-kernel, Dr. David Alan Gilbert
From: "Dr. David Alan Gilbert" <linux@treblig.org>
ena_com_get_dev_basic_stats() has been unused since 2017's
commit d81db2405613 ("net/ena: refactor ena_get_stats64 to be atomic
context safe")
ena_com_get_offload_settings() has been unused since the original
commit of ENA back in 2016 in
commit 1738cd3ed342 ("net: ena: Add a driver for Amazon Elastic
Network Adapters (ENA)")
Remove them.
Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
---
drivers/net/ethernet/amazon/ena/ena_com.c | 33 -----------------------
drivers/net/ethernet/amazon/ena/ena_com.h | 18 -------------
2 files changed, 51 deletions(-)
diff --git a/drivers/net/ethernet/amazon/ena/ena_com.c b/drivers/net/ethernet/amazon/ena/ena_com.c
index d958cda9e58b..bc23b8fa7a37 100644
--- a/drivers/net/ethernet/amazon/ena/ena_com.c
+++ b/drivers/net/ethernet/amazon/ena/ena_com.c
@@ -2198,21 +2198,6 @@ int ena_com_get_ena_srd_info(struct ena_com_dev *ena_dev,
return ret;
}
-int ena_com_get_dev_basic_stats(struct ena_com_dev *ena_dev,
- struct ena_admin_basic_stats *stats)
-{
- struct ena_com_stats_ctx ctx;
- int ret;
-
- memset(&ctx, 0x0, sizeof(ctx));
- ret = ena_get_dev_stats(ena_dev, &ctx, ENA_ADMIN_GET_STATS_TYPE_BASIC);
- if (likely(ret == 0))
- memcpy(stats, &ctx.get_resp.u.basic_stats,
- sizeof(ctx.get_resp.u.basic_stats));
-
- return ret;
-}
-
int ena_com_get_customer_metrics(struct ena_com_dev *ena_dev, char *buffer, u32 len)
{
struct ena_admin_aq_get_stats_cmd *get_cmd;
@@ -2289,24 +2274,6 @@ int ena_com_set_dev_mtu(struct ena_com_dev *ena_dev, u32 mtu)
return ret;
}
-int ena_com_get_offload_settings(struct ena_com_dev *ena_dev,
- struct ena_admin_feature_offload_desc *offload)
-{
- int ret;
- struct ena_admin_get_feat_resp resp;
-
- ret = ena_com_get_feature(ena_dev, &resp,
- ENA_ADMIN_STATELESS_OFFLOAD_CONFIG, 0);
- if (unlikely(ret)) {
- netdev_err(ena_dev->net_device, "Failed to get offload capabilities %d\n", ret);
- return ret;
- }
-
- memcpy(offload, &resp.u.offload, sizeof(resp.u.offload));
-
- return 0;
-}
-
int ena_com_set_hash_function(struct ena_com_dev *ena_dev)
{
struct ena_com_admin_queue *admin_queue = &ena_dev->admin_queue;
diff --git a/drivers/net/ethernet/amazon/ena/ena_com.h b/drivers/net/ethernet/amazon/ena/ena_com.h
index a372c5e768a7..20e1529adf3b 100644
--- a/drivers/net/ethernet/amazon/ena/ena_com.h
+++ b/drivers/net/ethernet/amazon/ena/ena_com.h
@@ -591,15 +591,6 @@ int ena_com_set_aenq_config(struct ena_com_dev *ena_dev, u32 groups_flag);
int ena_com_get_dev_attr_feat(struct ena_com_dev *ena_dev,
struct ena_com_dev_get_features_ctx *get_feat_ctx);
-/* ena_com_get_dev_basic_stats - Get device basic statistics
- * @ena_dev: ENA communication layer struct
- * @stats: stats return value
- *
- * @return: 0 on Success and negative value otherwise.
- */
-int ena_com_get_dev_basic_stats(struct ena_com_dev *ena_dev,
- struct ena_admin_basic_stats *stats);
-
/* ena_com_get_eni_stats - Get extended network interface statistics
* @ena_dev: ENA communication layer struct
* @stats: stats return value
@@ -635,15 +626,6 @@ int ena_com_get_customer_metrics(struct ena_com_dev *ena_dev, char *buffer, u32
*/
int ena_com_set_dev_mtu(struct ena_com_dev *ena_dev, u32 mtu);
-/* ena_com_get_offload_settings - Retrieve the device offloads capabilities
- * @ena_dev: ENA communication layer struct
- * @offlad: offload return value
- *
- * @return: 0 on Success and negative value otherwise.
- */
-int ena_com_get_offload_settings(struct ena_com_dev *ena_dev,
- struct ena_admin_feature_offload_desc *offload);
-
/* ena_com_rss_init - Init RSS
* @ena_dev: ENA communication layer struct
* @log_size: indirection log size
--
2.47.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] net: ena: Remove deadcode
2024-11-02 21:59 [PATCH] net: ena: Remove deadcode linux
@ 2024-11-02 22:02 ` Dr. David Alan Gilbert
0 siblings, 0 replies; 2+ messages in thread
From: Dr. David Alan Gilbert @ 2024-11-02 22:02 UTC (permalink / raw)
To: shayagr, akiyano, darinzon, ndagan, saeedb, andrew+netdev, davem,
edumazet, kuba, pabeni
Cc: netdev, linux-kernel
* linux@treblig.org (linux@treblig.org) wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
>
> ena_com_get_dev_basic_stats() has been unused since 2017's
> commit d81db2405613 ("net/ena: refactor ena_get_stats64 to be atomic
> context safe")
>
> ena_com_get_offload_settings() has been unused since the original
> commit of ENA back in 2016 in
> commit 1738cd3ed342 ("net: ena: Add a driver for Amazon Elastic
> Network Adapters (ENA)")
>
> Remove them.
>
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
Oops, resending with the net-next prefix on.
Dave
> ---
> drivers/net/ethernet/amazon/ena/ena_com.c | 33 -----------------------
> drivers/net/ethernet/amazon/ena/ena_com.h | 18 -------------
> 2 files changed, 51 deletions(-)
>
> diff --git a/drivers/net/ethernet/amazon/ena/ena_com.c b/drivers/net/ethernet/amazon/ena/ena_com.c
> index d958cda9e58b..bc23b8fa7a37 100644
> --- a/drivers/net/ethernet/amazon/ena/ena_com.c
> +++ b/drivers/net/ethernet/amazon/ena/ena_com.c
> @@ -2198,21 +2198,6 @@ int ena_com_get_ena_srd_info(struct ena_com_dev *ena_dev,
> return ret;
> }
>
> -int ena_com_get_dev_basic_stats(struct ena_com_dev *ena_dev,
> - struct ena_admin_basic_stats *stats)
> -{
> - struct ena_com_stats_ctx ctx;
> - int ret;
> -
> - memset(&ctx, 0x0, sizeof(ctx));
> - ret = ena_get_dev_stats(ena_dev, &ctx, ENA_ADMIN_GET_STATS_TYPE_BASIC);
> - if (likely(ret == 0))
> - memcpy(stats, &ctx.get_resp.u.basic_stats,
> - sizeof(ctx.get_resp.u.basic_stats));
> -
> - return ret;
> -}
> -
> int ena_com_get_customer_metrics(struct ena_com_dev *ena_dev, char *buffer, u32 len)
> {
> struct ena_admin_aq_get_stats_cmd *get_cmd;
> @@ -2289,24 +2274,6 @@ int ena_com_set_dev_mtu(struct ena_com_dev *ena_dev, u32 mtu)
> return ret;
> }
>
> -int ena_com_get_offload_settings(struct ena_com_dev *ena_dev,
> - struct ena_admin_feature_offload_desc *offload)
> -{
> - int ret;
> - struct ena_admin_get_feat_resp resp;
> -
> - ret = ena_com_get_feature(ena_dev, &resp,
> - ENA_ADMIN_STATELESS_OFFLOAD_CONFIG, 0);
> - if (unlikely(ret)) {
> - netdev_err(ena_dev->net_device, "Failed to get offload capabilities %d\n", ret);
> - return ret;
> - }
> -
> - memcpy(offload, &resp.u.offload, sizeof(resp.u.offload));
> -
> - return 0;
> -}
> -
> int ena_com_set_hash_function(struct ena_com_dev *ena_dev)
> {
> struct ena_com_admin_queue *admin_queue = &ena_dev->admin_queue;
> diff --git a/drivers/net/ethernet/amazon/ena/ena_com.h b/drivers/net/ethernet/amazon/ena/ena_com.h
> index a372c5e768a7..20e1529adf3b 100644
> --- a/drivers/net/ethernet/amazon/ena/ena_com.h
> +++ b/drivers/net/ethernet/amazon/ena/ena_com.h
> @@ -591,15 +591,6 @@ int ena_com_set_aenq_config(struct ena_com_dev *ena_dev, u32 groups_flag);
> int ena_com_get_dev_attr_feat(struct ena_com_dev *ena_dev,
> struct ena_com_dev_get_features_ctx *get_feat_ctx);
>
> -/* ena_com_get_dev_basic_stats - Get device basic statistics
> - * @ena_dev: ENA communication layer struct
> - * @stats: stats return value
> - *
> - * @return: 0 on Success and negative value otherwise.
> - */
> -int ena_com_get_dev_basic_stats(struct ena_com_dev *ena_dev,
> - struct ena_admin_basic_stats *stats);
> -
> /* ena_com_get_eni_stats - Get extended network interface statistics
> * @ena_dev: ENA communication layer struct
> * @stats: stats return value
> @@ -635,15 +626,6 @@ int ena_com_get_customer_metrics(struct ena_com_dev *ena_dev, char *buffer, u32
> */
> int ena_com_set_dev_mtu(struct ena_com_dev *ena_dev, u32 mtu);
>
> -/* ena_com_get_offload_settings - Retrieve the device offloads capabilities
> - * @ena_dev: ENA communication layer struct
> - * @offlad: offload return value
> - *
> - * @return: 0 on Success and negative value otherwise.
> - */
> -int ena_com_get_offload_settings(struct ena_com_dev *ena_dev,
> - struct ena_admin_feature_offload_desc *offload);
> -
> /* ena_com_rss_init - Init RSS
> * @ena_dev: ENA communication layer struct
> * @log_size: indirection log size
> --
> 2.47.0
>
--
-----Open up your eyes, open up your mind, open up your code -------
/ Dr. David Alan Gilbert | Running GNU/Linux | Happy \
\ dave @ treblig.org | | In Hex /
\ _________________________|_____ http://www.treblig.org |_______/
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-11-02 22:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-11-02 21:59 [PATCH] net: ena: Remove deadcode linux
2024-11-02 22:02 ` Dr. David Alan Gilbert
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).