From: Jakub Kicinski <kuba@kernel.org>
To: Wei Fang <wei.fang@nxp.com>
Cc: davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
andrew+netdev@lunn.ch, claudiu.manoil@nxp.com,
vladimir.oltean@nxp.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, imx@lists.linux.dev
Subject: Re: [PATCH net 0/2] Fix issues when PF sets MAC address for VF
Date: Sun, 3 Nov 2024 12:50:34 -0800 [thread overview]
Message-ID: <20241103125034.27c43c51@kernel.org> (raw)
In-Reply-To: <20241031060247.1290941-1-wei.fang@nxp.com>
On Thu, 31 Oct 2024 14:02:45 +0800 Wei Fang wrote:
> net: enetc: allocate vf_state during PF probes
> net: enetc: prevent PF from configuring MAC address for an enabled VF
This combination of changes would imply that nobody sets the MAC
address on VFs via this driver, correct? Patch 1 fixes a crash
if address is set before VFs are enabled, patch 2 forces setting
the MAC before VFs are enabled (which would previously crash).
Which leads me to believe this will cause regressions to all users,
if such users exist.
The fact that the MAC address is not picked up by a running VM is
normal, I'd say even maybe expected. IIUC hypervisor will enable
SRIOV at the start of day, then allocate, configure and assign VFs
to VMs. It will FLR the VF after configuration.
Your change will make it impossible to reconfigure VF with a MAC
of a new VM, if any other VF is in use.
Long story short, I don't believe the patch 2 is necessary at all,
maybe you can print a warning to the logs, if you really want.
next prev parent reply other threads:[~2024-11-03 20:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-31 6:02 [PATCH net 0/2] Fix issues when PF sets MAC address for VF Wei Fang
2024-10-31 6:02 ` [PATCH net 1/2] net: enetc: allocate vf_state during PF probes Wei Fang
2024-11-01 11:37 ` Vladimir Oltean
2024-10-31 6:02 ` [PATCH net 2/2] net: enetc: prevent PF from configuring MAC address for an enabled VF Wei Fang
2024-11-01 11:39 ` Vladimir Oltean
2024-11-03 20:50 ` Jakub Kicinski [this message]
2024-11-04 2:41 ` [PATCH net 0/2] Fix issues when PF sets MAC address for VF Wei Fang
2024-11-03 21:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241103125034.27c43c51@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=claudiu.manoil@nxp.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=imx@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=vladimir.oltean@nxp.com \
--cc=wei.fang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).