* [PATCH] net: ipv6: fix inconsistent indentation in ipv6_gro_receive
@ 2024-10-31 6:51 Suraj Sonawane
2024-11-03 23:22 ` Jakub Kicinski
0 siblings, 1 reply; 3+ messages in thread
From: Suraj Sonawane @ 2024-10-31 6:51 UTC (permalink / raw)
To: davem; +Cc: dsahern, edumazet, kuba, pabeni, netdev, linux-kernel,
Suraj Sonawane
Fix the indentation to ensure consistent code style and improve
readability, and to fix this warning:
net/ipv6/ip6_offload.c:280 ipv6_gro_receive() warn: inconsistent indenting
Signed-off-by: Suraj Sonawane <surajsonawane0215@gmail.com>
---
net/ipv6/ip6_offload.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/net/ipv6/ip6_offload.c b/net/ipv6/ip6_offload.c
index 982216342..e4c3ab837 100644
--- a/net/ipv6/ip6_offload.c
+++ b/net/ipv6/ip6_offload.c
@@ -277,10 +277,10 @@ INDIRECT_CALLABLE_SCOPE struct sk_buff *ipv6_gro_receive(struct list_head *head,
* (nlen != (sizeof(*iph2) + ipv6_exthdrs_len(iph2, &ops)))
* memcmp() alone below is sufficient, right?
*/
- if ((first_word & htonl(0xF00FFFFF)) ||
- !ipv6_addr_equal(&iph->saddr, &iph2->saddr) ||
- !ipv6_addr_equal(&iph->daddr, &iph2->daddr) ||
- iph->nexthdr != iph2->nexthdr) {
+ if ((first_word & htonl(0xF00FFFFF)) ||
+ !ipv6_addr_equal(&iph->saddr, &iph2->saddr) ||
+ !ipv6_addr_equal(&iph->daddr, &iph2->daddr) ||
+ iph->nexthdr != iph2->nexthdr) {
not_same_flow:
NAPI_GRO_CB(p)->same_flow = 0;
continue;
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] net: ipv6: fix inconsistent indentation in ipv6_gro_receive
2024-10-31 6:51 [PATCH] net: ipv6: fix inconsistent indentation in ipv6_gro_receive Suraj Sonawane
@ 2024-11-03 23:22 ` Jakub Kicinski
2024-11-05 5:10 ` Suraj Sonawane
0 siblings, 1 reply; 3+ messages in thread
From: Jakub Kicinski @ 2024-11-03 23:22 UTC (permalink / raw)
To: Suraj Sonawane; +Cc: davem, dsahern, edumazet, pabeni, netdev, linux-kernel
On Thu, 31 Oct 2024 12:21:24 +0530 Suraj Sonawane wrote:
> Fix the indentation to ensure consistent code style and improve
> readability, and to fix this warning:
>
> net/ipv6/ip6_offload.c:280 ipv6_gro_receive() warn: inconsistent indenting
Warning from what tool?
Unless it's gcc or clang let's leave the code be, it's fine.
--
pw-bot: cr
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net: ipv6: fix inconsistent indentation in ipv6_gro_receive
2024-11-03 23:22 ` Jakub Kicinski
@ 2024-11-05 5:10 ` Suraj Sonawane
0 siblings, 0 replies; 3+ messages in thread
From: Suraj Sonawane @ 2024-11-05 5:10 UTC (permalink / raw)
To: Jakub Kicinski; +Cc: davem, dsahern, edumazet, pabeni, netdev, linux-kernel
On 04/11/24 04:52, Jakub Kicinski wrote:
> On Thu, 31 Oct 2024 12:21:24 +0530 Suraj Sonawane wrote:
>> Fix the indentation to ensure consistent code style and improve
>> readability, and to fix this warning:
>>
>> net/ipv6/ip6_offload.c:280 ipv6_gro_receive() warn: inconsistent indenting
>
> Warning from what tool?
>
> Unless it's gcc or clang let's leave the code be, it's fine.
Thank you for the feedback and your time.
The warning was flagged by smatch, a static analysis tool.
Best regards,
Suraj Sonawane
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-11-05 5:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-31 6:51 [PATCH] net: ipv6: fix inconsistent indentation in ipv6_gro_receive Suraj Sonawane
2024-11-03 23:22 ` Jakub Kicinski
2024-11-05 5:10 ` Suraj Sonawane
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).