From: Jakub Kicinski <kuba@kernel.org>
To: Robin Murphy <robin.murphy@arm.com>
Cc: Arnd Bergmann <arnd@kernel.org>,
Jian Shen <shenjian15@huawei.com>,
Salil Mehta <salil.mehta@huawei.com>,
Arnd Bergmann <arnd@arndb.de>, Will Deacon <will@kernel.org>,
Joerg Roedel <jroedel@suse.de>,
iommu@lists.linux.dev, Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Jijie Shao <shaojijie@huawei.com>,
Peiyang Wang <wangpeiyang1@huawei.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [net-next] net: hns3: add IOMMU_SUPPORT dependency
Date: Mon, 4 Nov 2024 18:10:10 -0800 [thread overview]
Message-ID: <20241104181010.3d1a53f1@kernel.org> (raw)
In-Reply-To: <069c9838-b781-4012-934a-d2626fa78212@arm.com>
On Mon, 4 Nov 2024 10:29:28 +0000 Robin Murphy wrote:
> WTF is that patch doing!? No, random device drivers should absolutely
> not be poking into IOMMU driver internals, this is egregiously wrong and
> the correct action is to drop it entirely.
Sorry, reverted in
https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/commit/?id=249cfa318fb1b77eb726c2ff4f74c9685f04e568
prev parent reply other threads:[~2024-11-05 2:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-04 8:21 [PATCH] [net-next] net: hns3: add IOMMU_SUPPORT dependency Arnd Bergmann
2024-11-04 10:29 ` Robin Murphy
2024-11-04 10:40 ` Salil Mehta
2024-11-04 10:50 ` Salil Mehta
2024-11-04 16:34 ` Robin Murphy
2024-11-06 19:39 ` Salil Mehta
2024-11-04 12:01 ` Pranjal Shrivastava
2024-11-05 2:10 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241104181010.3d1a53f1@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=iommu@lists.linux.dev \
--cc=jroedel@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robin.murphy@arm.com \
--cc=salil.mehta@huawei.com \
--cc=shaojijie@huawei.com \
--cc=shenjian15@huawei.com \
--cc=wangpeiyang1@huawei.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).