From: Jakub Kicinski <kuba@kernel.org>
To: David Arinzon <darinzon@amazon.com>
Cc: David Miller <davem@davemloft.net>, <netdev@vger.kernel.org>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Richard Cochran <richardcochran@gmail.com>,
"Woodhouse, David" <dwmw@amazon.com>,
"Machulsky, Zorik" <zorik@amazon.com>,
"Matushevsky, Alexander" <matua@amazon.com>,
Saeed Bshara <saeedb@amazon.com>, "Wilson, Matt" <msw@amazon.com>,
"Liguori, Anthony" <aliguori@amazon.com>,
"Bshara, Nafea" <nafea@amazon.com>,
"Schmeilin, Evgeny" <evgenys@amazon.com>,
"Belgazal, Netanel" <netanel@amazon.com>,
"Saidi, Ali" <alisaidi@amazon.com>,
"Herrenschmidt, Benjamin" <benh@amazon.com>,
"Kiyanovski, Arthur" <akiyano@amazon.com>,
"Dagan, Noam" <ndagan@amazon.com>,
"Bernstein, Amit" <amitbern@amazon.com>,
"Agroskin, Shay" <shayagr@amazon.com>,
"Abboud, Osama" <osamaabb@amazon.com>,
"Ostrovsky, Evgeny" <evostrov@amazon.com>,
"Tabachnik, Ofir" <ofirt@amazon.com>,
"Machnikowski, Maciek" <maciek@machnikowski.net>
Subject: Re: [PATCH v3 net-next 3/3] net: ena: Add PHC documentation
Date: Mon, 4 Nov 2024 18:17:22 -0800 [thread overview]
Message-ID: <20241104181722.4ee86665@kernel.org> (raw)
In-Reply-To: <20241103113140.275-4-darinzon@amazon.com>
On Sun, 3 Nov 2024 13:31:39 +0200 David Arinzon wrote:
> +================= ======================================================
> +**phc_cnt** Number of successful retrieved timestamps (below expire timeout).
> +**phc_exp** Number of expired retrieved timestamps (above expire timeout).
> +**phc_skp** Number of skipped get time attempts (during block period).
> +**phc_err** Number of failed get time attempts (entering into block state).
> +================= ======================================================
I seem to recall we had an unpleasant conversation about using standard
stats recently. Please tell me where you looked to check if Linux has
standard stats for packet timestamping. We need to add the right info
there.
--
pw-bot: cr
next prev parent reply other threads:[~2024-11-05 2:17 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-03 11:31 [PATCH v3 net-next 0/3] PHC support in ENA driver David Arinzon
2024-11-03 11:31 ` [PATCH v3 net-next 1/3] net: ena: Add PHC support in the " David Arinzon
2024-11-03 11:31 ` [PATCH v3 net-next 2/3] net: ena: PHC silent reset David Arinzon
2024-11-03 11:31 ` [PATCH v3 net-next 3/3] net: ena: Add PHC documentation David Arinzon
2024-11-05 2:17 ` Jakub Kicinski [this message]
2024-11-05 10:52 ` Arinzon, David
2024-11-05 16:16 ` Gal Pressman
2024-11-05 16:52 ` Arinzon, David
2024-11-06 2:02 ` Rahul Rameshbabu
2024-11-06 2:15 ` Jakub Kicinski
2024-11-06 1:28 ` Jakub Kicinski
2024-11-12 17:53 ` Arinzon, David
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241104181722.4ee86665@kernel.org \
--to=kuba@kernel.org \
--cc=akiyano@amazon.com \
--cc=aliguori@amazon.com \
--cc=alisaidi@amazon.com \
--cc=amitbern@amazon.com \
--cc=benh@amazon.com \
--cc=darinzon@amazon.com \
--cc=davem@davemloft.net \
--cc=dwmw@amazon.com \
--cc=edumazet@google.com \
--cc=evgenys@amazon.com \
--cc=evostrov@amazon.com \
--cc=maciek@machnikowski.net \
--cc=matua@amazon.com \
--cc=msw@amazon.com \
--cc=nafea@amazon.com \
--cc=ndagan@amazon.com \
--cc=netanel@amazon.com \
--cc=netdev@vger.kernel.org \
--cc=ofirt@amazon.com \
--cc=osamaabb@amazon.com \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=saeedb@amazon.com \
--cc=shayagr@amazon.com \
--cc=zorik@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).