From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BD98D1CB53F; Tue, 5 Nov 2024 13:30:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730813448; cv=none; b=qg7gX1amzJPBvnJ+OMkkCYz7elmTSfxhKbA05vQhIAGsdIPz1UB7VtxvCM1OqgxtmqdmNUYUM1zrQHCicTim8wk2DFPF2VkfFkdHnwp98QuWae2s7xHyD2Mq9hN4lCglnnFgJyM1PyoklPwhNpmXWNXZy7v9ETN507rszQ8IjTI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730813448; c=relaxed/simple; bh=Fi5OBe+H2dD2yZvTh/WNAXkg+PHAKQE103t4mSCoE6I=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=pyw5fw3AqqA1x5rVUS1+nee91PrAIpBqseXFAO4SOe0wXsH6Fbmc4bhY+F6X5m+jTeR/utErTCTYJYZwIxcL4uDp2/dkXZ6sDC4J6XWStzwJDBwS5nlqMhjZ2M/Rc0mobMizHe/Vla2seqzYfQIHOI7uSvpTbpC1Df2nM6ig5Vc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=g/8+X5R8; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="g/8+X5R8" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1BCD2C4CECF; Tue, 5 Nov 2024 13:30:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1730813448; bh=Fi5OBe+H2dD2yZvTh/WNAXkg+PHAKQE103t4mSCoE6I=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=g/8+X5R8bxGCoooBLzpt/xpMED05V65S/xyQ0tJuGzrOV4+ZBlbqwla7dpb2n9/mE SN54rlxrraTZsqkP8hConwzM83tEDPL6q8drBGnOYy/U8GUDQANFEibVCt0/PDIYMm xWiG3EHjFMK9HXzHQwabfGTNYxmgRiXu41u+Mq3QK20D/1lqtkQ2aGHKGJVQqU1WTv JSRMcJ8QF89s+gM5rqps7hCyInfWGGvTdyMWJGQo3AGZEby4Jva4+FjWsaU/D5L37+ OhVxj1+eMYgZGL30lSy7pkXq7sQ8l0YxzDjASZhw82FcDeItpcXEelEZ9g79X1MnPA A1vPGeXvQZjfw== Date: Tue, 5 Nov 2024 13:30:42 +0000 From: Simon Horman To: Roger Quadros Cc: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Vignesh Raghavendra , Maxime Chevallier , Siddharth Vadapalli , Md Danish Anwar , Govindarajan Sriramakrishnan , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org Subject: Re: [PATCH net v3 2/2] net: ethernet: ti: am65-cpsw: fix warning in am65_cpsw_nuss_remove_rx_chns() Message-ID: <20241105133042.GD4507@kernel.org> References: <20241101-am65-cpsw-multi-rx-j7-fix-v3-0-338fdd6a55da@kernel.org> <20241101-am65-cpsw-multi-rx-j7-fix-v3-2-338fdd6a55da@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241101-am65-cpsw-multi-rx-j7-fix-v3-2-338fdd6a55da@kernel.org> On Fri, Nov 01, 2024 at 12:18:51PM +0200, Roger Quadros wrote: > flow->irq is initialized to 0 which is a valid IRQ. Set it to -EINVAL > in error path of am65_cpsw_nuss_init_rx_chns() so we do not try > to free an unallocated IRQ in am65_cpsw_nuss_remove_rx_chns(). > > If user tried to change number of RX queues and am65_cpsw_nuss_init_rx_chns() > failed due to any reason, the warning will happen if user tries to change > the number of RX queues after the error condition. > > root@am62xx-evm:~# ethtool -L eth0 rx 3 > [ 40.385293] am65-cpsw-nuss 8000000.ethernet: set new flow-id-base 19 > [ 40.393211] am65-cpsw-nuss 8000000.ethernet: Failed to init rx flow2 > netlink error: Invalid argument > root@am62xx-evm:~# ethtool -L eth0 rx 2 > [ 82.306427] ------------[ cut here ]------------ > [ 82.311075] WARNING: CPU: 0 PID: 378 at kernel/irq/devres.c:144 devm_free_irq+0x84/0x90 > [ 82.469770] Call trace: > [ 82.472208] devm_free_irq+0x84/0x90 > [ 82.475777] am65_cpsw_nuss_remove_rx_chns+0x6c/0xac [ti_am65_cpsw_nuss] > [ 82.482487] am65_cpsw_nuss_update_tx_rx_chns+0x2c/0x9c [ti_am65_cpsw_nuss] > [ 82.489442] am65_cpsw_set_channels+0x30/0x4c [ti_am65_cpsw_nuss] > [ 82.495531] ethnl_set_channels+0x224/0x2dc > [ 82.499713] ethnl_default_set_doit+0xb8/0x1b8 > [ 82.504149] genl_family_rcv_msg_doit+0xc0/0x124 > [ 82.508757] genl_rcv_msg+0x1f0/0x284 > [ 82.512409] netlink_rcv_skb+0x58/0x130 > [ 82.516239] genl_rcv+0x38/0x50 > [ 82.519374] netlink_unicast+0x1d0/0x2b0 > [ 82.523289] netlink_sendmsg+0x180/0x3c4 > [ 82.527205] __sys_sendto+0xe4/0x158 > [ 82.530779] __arm64_sys_sendto+0x28/0x38 > [ 82.534782] invoke_syscall+0x44/0x100 > [ 82.538526] el0_svc_common.constprop.0+0xc0/0xe0 > [ 82.543221] do_el0_svc+0x1c/0x28 > [ 82.546528] el0_svc+0x28/0x98 > [ 82.549578] el0t_64_sync_handler+0xc0/0xc4 > [ 82.553752] el0t_64_sync+0x190/0x194 > [ 82.557407] ---[ end trace 0000000000000000 ]--- > > Fixes: da70d184a8c3 ("net: ethernet: ti: am65-cpsw: Introduce multi queue Rx") Hi Roger, I wonder if the problem predates the cited commit and was, rather, introduced by: Fixes: 24bc19b05f1f ("net: ethernet: ti: am65-cpsw: Add suspend/resume support") ...