From: Jakub Kicinski <kuba@kernel.org>
To: "Arinzon, David" <darinzon@amazon.com>
Cc: David Miller <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Richard Cochran <richardcochran@gmail.com>,
"Woodhouse, David" <dwmw@amazon.co.uk>,
"Machulsky, Zorik" <zorik@amazon.com>,
"Matushevsky, Alexander" <matua@amazon.com>,
"Bshara, Saeed" <saeedb@amazon.com>,
"Wilson, Matt" <msw@amazon.com>,
"Liguori, Anthony" <aliguori@amazon.com>,
"Bshara, Nafea" <nafea@amazon.com>,
"Schmeilin, Evgeny" <evgenys@amazon.com>,
"Belgazal, Netanel" <netanel@amazon.com>,
"Saidi, Ali" <alisaidi@amazon.com>,
"Herrenschmidt, Benjamin" <benh@amazon.com>,
"Kiyanovski, Arthur" <akiyano@amazon.com>,
"Dagan, Noam" <ndagan@amazon.com>,
"Bernstein, Amit" <amitbern@amazon.com>,
"Agroskin, Shay" <shayagr@amazon.com>,
"Abboud, Osama" <osamaabb@amazon.com>,
"Ostrovsky, Evgeny" <evostrov@amazon.com>,
"Tabachnik, Ofir" <ofirt@amazon.com>,
"Machnikowski, Maciek" <maciek@machnikowski.net>
Subject: Re: [PATCH v3 net-next 3/3] net: ena: Add PHC documentation
Date: Tue, 5 Nov 2024 17:28:58 -0800 [thread overview]
Message-ID: <20241105172858.273df3fd@kernel.org> (raw)
In-Reply-To: <4ce957d04f6048f9bf607826e9e0be5b@amazon.com>
On Tue, 5 Nov 2024 10:52:12 +0000 Arinzon, David wrote:
> Just wanted to clarify that this feature and the associated
> documentation are specifically intended for reading a HW timestamp,
> not for TX/RX packet timestamping.
Oh, so you're saying you can only read the clock from the device?
The word timestamp means time associated with an event.
In the doc you talk about:
> +PHC support and capabilities can be verified using ethtool:
> +
> +.. code-block:: shell
> +
> + ethtool -T <interface>
which is for packet timestamping
also:
> ENA Linux driver supports PTP hardware clock providing timestamp
> reference to achieve nanosecond accuracy.
You probably want to double check the definitions of accuracy and
resolution.
We recently merged an Amazon PTP clock driver from David Woodhouse,
see commit 20503272422693. If you're not timestamping packets why
not use that driver?
next prev parent reply other threads:[~2024-11-06 1:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-03 11:31 [PATCH v3 net-next 0/3] PHC support in ENA driver David Arinzon
2024-11-03 11:31 ` [PATCH v3 net-next 1/3] net: ena: Add PHC support in the " David Arinzon
2024-11-03 11:31 ` [PATCH v3 net-next 2/3] net: ena: PHC silent reset David Arinzon
2024-11-03 11:31 ` [PATCH v3 net-next 3/3] net: ena: Add PHC documentation David Arinzon
2024-11-05 2:17 ` Jakub Kicinski
2024-11-05 10:52 ` Arinzon, David
2024-11-05 16:16 ` Gal Pressman
2024-11-05 16:52 ` Arinzon, David
2024-11-06 2:02 ` Rahul Rameshbabu
2024-11-06 2:15 ` Jakub Kicinski
2024-11-06 1:28 ` Jakub Kicinski [this message]
2024-11-12 17:53 ` Arinzon, David
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241105172858.273df3fd@kernel.org \
--to=kuba@kernel.org \
--cc=akiyano@amazon.com \
--cc=aliguori@amazon.com \
--cc=alisaidi@amazon.com \
--cc=amitbern@amazon.com \
--cc=benh@amazon.com \
--cc=darinzon@amazon.com \
--cc=davem@davemloft.net \
--cc=dwmw@amazon.co.uk \
--cc=edumazet@google.com \
--cc=evgenys@amazon.com \
--cc=evostrov@amazon.com \
--cc=maciek@machnikowski.net \
--cc=matua@amazon.com \
--cc=msw@amazon.com \
--cc=nafea@amazon.com \
--cc=ndagan@amazon.com \
--cc=netanel@amazon.com \
--cc=netdev@vger.kernel.org \
--cc=ofirt@amazon.com \
--cc=osamaabb@amazon.com \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=saeedb@amazon.com \
--cc=shayagr@amazon.com \
--cc=zorik@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).