* [PATCH] Revert "igb: Disable threaded IRQ for igb_msix_other"
@ 2024-11-04 12:40 Wander Lairson Costa
2024-11-06 1:54 ` Jakub Kicinski
0 siblings, 1 reply; 2+ messages in thread
From: Wander Lairson Costa @ 2024-11-04 12:40 UTC (permalink / raw)
To: Tony Nguyen, Przemek Kitszel, Andrew Lunn, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Sebastian Andrzej Siewior, Clark Williams, Steven Rostedt,
moderated list:INTEL ETHERNET DRIVERS,
open list:NETWORKING DRIVERS, open list,
open list:Real-time Linux (PREEMPT_RT):Keyword:PREEMPT_RT
Cc: tglx, Wander Lairson Costa
This reverts commit 338c4d3902feb5be49bfda530a72c7ab860e2c9f.
Sebastian noticed the ISR indirectly acquires spin_locks, which are
sleeping locks under PREEMPT_RT, which leads to kernel splats.
Signed-off-by: Wander Lairson Costa <wander@redhat.com>
Reported-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
---
drivers/net/ethernet/intel/igb/igb_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c
index b83df5f94b1f..f1d088168723 100644
--- a/drivers/net/ethernet/intel/igb/igb_main.c
+++ b/drivers/net/ethernet/intel/igb/igb_main.c
@@ -907,7 +907,7 @@ static int igb_request_msix(struct igb_adapter *adapter)
int i, err = 0, vector = 0, free_vector = 0;
err = request_irq(adapter->msix_entries[vector].vector,
- igb_msix_other, IRQF_NO_THREAD, netdev->name, adapter);
+ igb_msix_other, 0, netdev->name, adapter);
if (err)
goto err_out;
--
2.47.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Revert "igb: Disable threaded IRQ for igb_msix_other"
2024-11-04 12:40 [PATCH] Revert "igb: Disable threaded IRQ for igb_msix_other" Wander Lairson Costa
@ 2024-11-06 1:54 ` Jakub Kicinski
0 siblings, 0 replies; 2+ messages in thread
From: Jakub Kicinski @ 2024-11-06 1:54 UTC (permalink / raw)
To: Wander Lairson Costa
Cc: Tony Nguyen, Przemek Kitszel, Andrew Lunn, David S. Miller,
Eric Dumazet, Paolo Abeni, Sebastian Andrzej Siewior,
Clark Williams, Steven Rostedt,
moderated list:INTEL ETHERNET DRIVERS,
open list:NETWORKING DRIVERS, open list,
open list:Real-time Linux (PREEMPT_RT):Keyword:PREEMPT_RT, tglx
On Mon, 4 Nov 2024 09:40:50 -0300 Wander Lairson Costa wrote:
> This reverts commit 338c4d3902feb5be49bfda530a72c7ab860e2c9f.
>
> Sebastian noticed the ISR indirectly acquires spin_locks, which are
> sleeping locks under PREEMPT_RT, which leads to kernel splats.
>
> Signed-off-by: Wander Lairson Costa <wander@redhat.com>
> Reported-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Please resend with the reverted commit added as a Fixes tag.
Also - your sign off should be the last tag.
--
pw-bot: au
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-11-06 1:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-11-04 12:40 [PATCH] Revert "igb: Disable threaded IRQ for igb_msix_other" Wander Lairson Costa
2024-11-06 1:54 ` Jakub Kicinski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).