From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BBE0E1DED58; Wed, 6 Nov 2024 12:25:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730895945; cv=none; b=t/iZGgwf+zaWl53wpjwMlArQaII+B5Flsj+y8t5dEXUeHsjIO9IhbMlLFQAy4Da5E6l8SDdbCB1bHMToWT9vURZQ9BO0rKad/hRX5uLszeMqP4js1UN7c7nv6vV7EI8hZJy+84hmNq49DC3X1NpxGSlyWumXG6dEfWCICP4SdlA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730895945; c=relaxed/simple; bh=Ql0f9QPXZsz6XdIg7YqDkg3ZcReNtMqKbXcsPh4THk4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=MeIJOy5aQ2yw/1yBEDM2TfZVTGE3KvCiFm6jsRtRMtzE76AYnqLbkWFynghQysSbuzrZX2eWdJKQUuLKM1iV+925Zw7jYkYld94TqnfKvIdqav3OGX4Vw6A9Dp8q0VzFvdmFJHixVifAx1h3OrW0/WmR5soMStG4vdnJUr7Z1U4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=kqgGJR2v; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="kqgGJR2v" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D0FA1C4CED4; Wed, 6 Nov 2024 12:25:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1730895945; bh=Ql0f9QPXZsz6XdIg7YqDkg3ZcReNtMqKbXcsPh4THk4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=kqgGJR2vg6yW0GbXr/07HyoG2ZjnHYy/zc/yUAZlM/n0M2PTrarAakyYsjTLoW+KL UMynVwNeUTxUeXWk3IWVJjNtqGHy0+dhDsSmkip4sxV3BF4byKz40/7pgT8RD4vsAd WLx89nIwsYKNmtMy9nEZuEXCkUyQj62VpIgHdmEfcm8VFi2d6JynDFhx36OjzFnL4n hnkjZCVp4H4p7SNzN4d2EKY+L9s9C1Bm6yYNrhycI0w1JC2LRkT5F2/B1AqEKTGm/D PmpCqHpqL42QbAjxsY6bd43j3kea3/gB80rTaKL3w0DWDCPLya6S+HADVw8cpb+Tz9 NHKQcuD5oxFIQ== Date: Wed, 6 Nov 2024 14:25:41 +0200 From: Leon Romanovsky To: Wenjia Zhang Cc: David Miller , Jakub Kicinski , Eric Dumazet , Paolo Abeni , netdev@vger.kernel.org, linux-s390@vger.kernel.org, linux-rdma@vger.kernel.org, Simon Horman , Michael Guralnik , Heiko Carstens , Wen Gu , "D. Wythe" , Tony Lu , Jan Karcher , Gerd Bayer , Alexandra Winter , Halil Pasic , Nils Hoppmann , Niklas Schnell , Thorsten Winkler , Karsten Graul , Stefan Raspl , Aswin K , Dust Li , Zhu Yanjun Subject: Re: [PATCH net v2] net/smc: Fix lookup of netdev by using ib_device_get_netdev() Message-ID: <20241106122541.GD5006@unreal> References: <20241106082612.57803-1-wenjia@linux.ibm.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241106082612.57803-1-wenjia@linux.ibm.com> On Wed, Nov 06, 2024 at 09:26:12AM +0100, Wenjia Zhang wrote: > The SMC-R variant of the SMC protocol used direct call to function > ib_device_ops.get_netdev() to lookup netdev. As we used mlx5 device > driver to run SMC-R, it failed to find a device, because in mlx5_ib the > internal net device management for retrieving net devices was replaced > by a common interface ib_device_get_netdev() in commit 8d159eb2117b > ("RDMA/mlx5: Use IB set_netdev and get_netdev functions"). > > Since such direct accesses to the internal net device management is not > recommended at all, update the SMC-R code to use proper API > ib_device_get_netdev(). > > Fixes: 54903572c23c ("net/smc: allow pnetid-less configuration") > Reported-by: Aswin K > Reviewed-by: Gerd Bayer > Reviewed-by: Halil Pasic > Reviewed-by: Simon Horman > Reviewed-by: Dust Li > Reviewed-by: Wen Gu > Reviewed-by: Zhu Yanjun > Reviewed-by: D. Wythe > Signed-off-by: Wenjia Zhang > --- > net/smc/smc_ib.c | 8 ++------ > net/smc/smc_pnet.c | 4 +--- > 2 files changed, 3 insertions(+), 9 deletions(-) > Thanks, Reviewed-by: Leon Romanovsky