[PATCH] mptcp: remove the redundant assignment of 'new_ctx->tcp_sock' in subflow_ulp_clone()

[PATCH] mptcp: remove the redundant assignment of 'new_ctx->tcp_sock' in subflow_ulp_clone()

[MoYuanhao]

The variable has already been assigned in the subflow_create_ctx(),
So we don't need to reassign this variable in the subflow_ulp_clone().

Signed-off-by: MoYuanhao <moyuanhao3676@163.com>
---
 net/mptcp/subflow.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/net/mptcp/subflow.c b/net/mptcp/subflow.c
index 07352b15f145..fd021cf8286e 100644
--- a/net/mptcp/subflow.c
+++ b/net/mptcp/subflow.c
@@ -2049,7 +2049,6 @@ static void subflow_ulp_clone(const struct request_sock *req,
 	new_ctx->tcp_state_change = old_ctx->tcp_state_change;
 	new_ctx->tcp_error_report = old_ctx->tcp_error_report;
 	new_ctx->rel_write_seq = 1;
-	new_ctx->tcp_sock = newsk;
 
 	if (subflow_req->mp_capable) {
 		/* see comments in subflow_syn_recv_sock(), MPTCP connection
-- 
2.25.1

Re: [PATCH] mptcp: remove the redundant assignment of 'new_ctx->tcp_sock' in subflow_ulp_clone()

[Matthieu Baerts]

Hi MoYuanhao, Netdev maintainers,

On 06/11/2024 08:10, MoYuanhao wrote:
> The variable has already been assigned in the subflow_create_ctx(),
> So we don't need to reassign this variable in the subflow_ulp_clone().

Good catch, no need to reassign it there.

Reviewed-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>


I guess this patch is for net-next. Please next time clearly indicate
for which tree this patch is for, by adding this in the patch prefix:

  [PATCH net-next]

See: https://docs.kernel.org/process/maintainer-netdev.html

Also, please try to keep the patch title under ~50 chars.


@Netdev maintainers: is it OK for you to apply this small patch in
net-next directly?


Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.

Re: [PATCH] mptcp: remove the redundant assignment of 'new_ctx->tcp_sock' in subflow_ulp_clone()

[Jakub Kicinski]

On Wed, 6 Nov 2024 16:41:10 +0100 Matthieu Baerts wrote:
> @Netdev maintainers: is it OK for you to apply this small patch in
> net-next directly?

Too soon for me to take it right now but yes.

Re: [PATCH] mptcp: remove the redundant assignment of 'new_ctx->tcp_sock' in subflow_ulp_clone()

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Wed,  6 Nov 2024 15:10:35 +0800 you wrote:
> The variable has already been assigned in the subflow_create_ctx(),
> So we don't need to reassign this variable in the subflow_ulp_clone().
> 
> Signed-off-by: MoYuanhao <moyuanhao3676@163.com>
> ---
>  net/mptcp/subflow.c | 1 -
>  1 file changed, 1 deletion(-)

Here is the summary with links:
  - mptcp: remove the redundant assignment of 'new_ctx->tcp_sock' in subflow_ulp_clone()
    https://git.kernel.org/netdev/net-next/c/7d28f4fc868c

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html