netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: andrew@lunn.ch
Cc: Andy Yan <andyshrk@163.com>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	david.wu@rock-chips.com, Johan Jonker <jbx6244@gmail.com>,
	Andy Yan <andy.yan@rock-chips.com>
Subject: Re: [PATCH v2 2/2] net: arc: rockchip: fix emac mdio node support
Date: Wed, 6 Nov 2024 17:50:02 -0800	[thread overview]
Message-ID: <20241106175002.645e2421@kernel.org> (raw)
In-Reply-To: <20241104130147.440125-3-andyshrk@163.com>

On Mon,  4 Nov 2024 21:01:39 +0800 Andy Yan wrote:
> From: Johan Jonker <jbx6244@gmail.com>
> 
> The binding emac_rockchip.txt is converted to YAML.
> Changed against the original binding is an added MDIO subnode.
> This make the driver failed to find the PHY, and given the 'mdio
> has invalid PHY address' it is probably looking in the wrong node.
> Fix emac_mdio.c so that it can handle both old and new
> device trees.

Andrew, looks good?

  reply	other threads:[~2024-11-07  1:50 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-04 13:01 [PATCH v2 0/2] Fix the arc emac driver Andy Yan
2024-11-04 13:01 ` [PATCH v2 1/2] net: arc: fix the device for dma_map_single/dma_unmap_single Andy Yan
2024-11-04 13:01 ` [PATCH v2 2/2] net: arc: rockchip: fix emac mdio node support Andy Yan
2024-11-07  1:50   ` Jakub Kicinski [this message]
2024-11-07  3:05     ` Andrew Lunn
2024-11-07 13:00 ` [PATCH v2 0/2] Fix the arc emac driver patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241106175002.645e2421@kernel.org \
    --to=kuba@kernel.org \
    --cc=andrew@lunn.ch \
    --cc=andy.yan@rock-chips.com \
    --cc=andyshrk@163.com \
    --cc=david.wu@rock-chips.com \
    --cc=jbx6244@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).