From: Jacob Keller <jacob.e.keller@intel.com>
To: Vladimir Oltean <olteanv@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>,
Tony Nguyen <anthony.l.nguyen@intel.com>,
Przemek Kitszel <przemyslaw.kitszel@intel.com>,
Masahiro Yamada <masahiroy@kernel.org>,
netdev <netdev@vger.kernel.org>
Cc: linux-kbuild@vger.kernel.org, Jacob Keller <jacob.e.keller@intel.com>
Subject: [PATCH net-next v3 4/9] ice: remove int_q_state from ice_tlan_ctx
Date: Thu, 07 Nov 2024 11:50:35 -0800 [thread overview]
Message-ID: <20241107-packing-pack-fields-and-ice-implementation-v3-4-27c566ac2436@intel.com> (raw)
In-Reply-To: <20241107-packing-pack-fields-and-ice-implementation-v3-0-27c566ac2436@intel.com>
The int_q_state field of the ice_tlan_ctx structure represents the internal
queue state. However, we never actually need to assign this or read this
during normal operation. In fact, trying to unpack it would not be possible
as it is larger than a u64. Remove this field from the ice_tlan_ctx
structure, and remove its packing field from the ice_tlan_ctx_info array.
Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
---
drivers/net/ethernet/intel/ice/ice_lan_tx_rx.h | 1 -
drivers/net/ethernet/intel/ice/ice_common.c | 1 -
2 files changed, 2 deletions(-)
diff --git a/drivers/net/ethernet/intel/ice/ice_lan_tx_rx.h b/drivers/net/ethernet/intel/ice/ice_lan_tx_rx.h
index 611577ebc29d..0e8ed8c226e6 100644
--- a/drivers/net/ethernet/intel/ice/ice_lan_tx_rx.h
+++ b/drivers/net/ethernet/intel/ice/ice_lan_tx_rx.h
@@ -590,7 +590,6 @@ struct ice_tlan_ctx {
u8 drop_ena;
u8 cache_prof_idx;
u8 pkt_shaper_prof_idx;
- u8 int_q_state; /* width not needed - internal - DO NOT WRITE!!! */
};
#endif /* _ICE_LAN_TX_RX_H_ */
diff --git a/drivers/net/ethernet/intel/ice/ice_common.c b/drivers/net/ethernet/intel/ice/ice_common.c
index b22e71dc59d4..0f5a80269a7b 100644
--- a/drivers/net/ethernet/intel/ice/ice_common.c
+++ b/drivers/net/ethernet/intel/ice/ice_common.c
@@ -1467,7 +1467,6 @@ const struct ice_ctx_ele ice_tlan_ctx_info[] = {
ICE_CTX_STORE(ice_tlan_ctx, drop_ena, 1, 165),
ICE_CTX_STORE(ice_tlan_ctx, cache_prof_idx, 2, 166),
ICE_CTX_STORE(ice_tlan_ctx, pkt_shaper_prof_idx, 3, 168),
- ICE_CTX_STORE(ice_tlan_ctx, int_q_state, 122, 171),
{ 0 }
};
--
2.47.0.265.g4ca455297942
next prev parent reply other threads:[~2024-11-07 19:50 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-07 19:50 [PATCH net-next v3 0/9] lib: packing: introduce and use (un)pack_fields Jacob Keller
2024-11-07 19:50 ` [PATCH net-next v3 1/9] lib: packing: create __pack() and __unpack() variants without error checking Jacob Keller
2024-11-07 19:50 ` [PATCH net-next v3 2/9] lib: packing: demote truncation error in pack() to a warning in __pack() Jacob Keller
2024-11-07 19:50 ` [PATCH net-next v3 3/9] lib: packing: add pack_fields() and unpack_fields() Jacob Keller
2024-11-08 7:47 ` kernel test robot
2024-11-08 11:24 ` Vladimir Oltean
2024-11-08 18:31 ` Vladimir Oltean
2024-11-08 22:53 ` Jacob Keller
2024-11-08 22:49 ` Jacob Keller
2024-11-07 19:50 ` Jacob Keller [this message]
2024-11-07 19:50 ` [PATCH net-next v3 5/9] ice: use structures to keep track of queue context size Jacob Keller
2024-11-07 19:50 ` [PATCH net-next v3 6/9] ice: use <linux/packing.h> for Tx and Rx queue context data Jacob Keller
2024-11-08 8:08 ` kernel test robot
2024-11-07 19:50 ` [PATCH net-next v3 7/9] ice: reduce size of queue context fields Jacob Keller
2024-11-07 19:50 ` [PATCH net-next v3 8/9] ice: move prefetch enable to ice_setup_rx_ctx Jacob Keller
2024-11-07 19:50 ` [PATCH net-next v3 9/9] ice: cleanup Rx queue context programming functions Jacob Keller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241107-packing-pack-fields-and-ice-implementation-v3-4-27c566ac2436@intel.com \
--to=jacob.e.keller@intel.com \
--cc=akpm@linux-foundation.org \
--cc=anthony.l.nguyen@intel.com \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox