From: Kuniyuki Iwashima <kuniyu@amazon.com>
To: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
Marc Kleine-Budde <mkl@pengutronix.de>,
Vincent Mailhol <mailhol.vincent@wanadoo.fr>,
"Daniel Borkmann" <daniel@iogearbox.net>,
Nikolay Aleksandrov <razor@blackwall.org>,
Kuniyuki Iwashima <kuniyu@amazon.com>,
Kuniyuki Iwashima <kuni1840@gmail.com>, <netdev@vger.kernel.org>
Subject: [PATCH v3 net-next 00/10] rtnetlink: Convert rtnl_newlink() to per-netns RTNL.
Date: Wed, 6 Nov 2024 18:28:50 -0800 [thread overview]
Message-ID: <20241107022900.70287-1-kuniyu@amazon.com> (raw)
Patch 1 - 3 removes __rtnl_link_unregister() and protects link_ops by
its dedicated mutex to move synchronize_srcu() out of the RTNL scope.
Patch 4 introduces struct rtnl_nets and helper functions to acquire
multiple per-netns RTNL in rtnl_newlink().
Patch 5 - 8 are to prefetch the peer device's netns in rtnl_newlink().
Patch 9 converts rtnl_newlink() to per-netns RTNL.
Patch 10 pushes RTNL down to rtnl_dellink() and rtnl_setlink(), but
the conversion will not be completed unless we support cases with
peer/upper/lower devices.
I confirmed v3 survived ./rtnetlink.sh; rmmod netdevsim.ko; without
lockdep splat.
Changes:
v3:
* Add patch 1~3 to avoid SRCU & RTNL deadlock
v2: https://lore.kernel.org/netdev/20241106022432.13065-1-kuniyu@amazon.com/
* Patch 1
* Move struct rtnl_nets to rtnetlink.c
* Unexport rtnl_nets_add()
* Patch 2
* Rename the helper to rtnl_link_get_net_ifla()
* Unexport rtnl_link_get_net_ifla()
* Change peer_type to u16
* Patch 6
* Remove __rtnl_unlock() dance
v1: https://lore.kernel.org/netdev/20241105020514.41963-1-kuniyu@amazon.com/
Kuniyuki Iwashima (10):
rtnetlink: Remove __rtnl_link_unregister().
rtnetlink: Protect link_ops by mutex.
rtnetlink: Remove __rtnl_link_register()
rtnetlink: Introduce struct rtnl_nets and helpers.
rtnetlink: Add peer_type in struct rtnl_link_ops.
veth: Set VETH_INFO_PEER to veth_link_ops.peer_type.
vxcan: Set VXCAN_INFO_PEER to vxcan_link_ops.peer_type.
netkit: Set IFLA_NETKIT_PEER_INFO to netkit_link_ops.peer_type.
rtnetlink: Convert RTM_NEWLINK to per-netns RTNL.
rtnetlink: Register rtnl_dellink() and rtnl_setlink() with
RTNL_FLAG_DOIT_PERNET_WIP.
drivers/net/can/vxcan.c | 12 +-
drivers/net/dummy.c | 17 ++-
drivers/net/ifb.c | 17 ++-
drivers/net/netkit.c | 11 +-
drivers/net/veth.c | 18 +--
include/net/rtnetlink.h | 8 +-
net/core/net_namespace.c | 1 -
net/core/rtnetlink.c | 257 ++++++++++++++++++++++++++++-----------
8 files changed, 217 insertions(+), 124 deletions(-)
--
2.39.5 (Apple Git-154)
next reply other threads:[~2024-11-07 2:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-07 2:28 Kuniyuki Iwashima [this message]
2024-11-07 2:28 ` [PATCH v3 net-next 01/10] rtnetlink: Remove __rtnl_link_unregister() Kuniyuki Iwashima
2024-11-07 2:28 ` [PATCH v3 net-next 02/10] rtnetlink: Protect link_ops by mutex Kuniyuki Iwashima
2024-11-07 2:28 ` [PATCH v3 net-next 03/10] rtnetlink: Remove __rtnl_link_register() Kuniyuki Iwashima
2024-11-07 2:28 ` [PATCH v3 net-next 04/10] rtnetlink: Introduce struct rtnl_nets and helpers Kuniyuki Iwashima
2024-11-07 2:28 ` [PATCH v3 net-next 06/10] veth: Set VETH_INFO_PEER to veth_link_ops.peer_type Kuniyuki Iwashima
2024-11-07 2:28 ` [PATCH v3 net-next 07/10] vxcan: Set VXCAN_INFO_PEER to vxcan_link_ops.peer_type Kuniyuki Iwashima
2024-11-07 2:28 ` [PATCH v3 net-next 08/10] netkit: Set IFLA_NETKIT_PEER_INFO to netkit_link_ops.peer_type Kuniyuki Iwashima
2024-11-07 2:28 ` [PATCH v3 net-next 09/10] rtnetlink: Convert RTM_NEWLINK to per-netns RTNL Kuniyuki Iwashima
2024-11-07 2:29 ` [PATCH v3 net-next 10/10] rtnetlink: Register rtnl_dellink() and rtnl_setlink() with RTNL_FLAG_DOIT_PERNET_WIP Kuniyuki Iwashima
2024-11-07 23:53 ` [PATCH v3 net-next 00/10] rtnetlink: Convert rtnl_newlink() to per-netns RTNL Jakub Kicinski
2024-11-08 0:02 ` Kuniyuki Iwashima
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241107022900.70287-1-kuniyu@amazon.com \
--to=kuniyu@amazon.com \
--cc=andrew+netdev@lunn.ch \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=kuni1840@gmail.com \
--cc=mailhol.vincent@wanadoo.fr \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=razor@blackwall.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).