From: Jakub Kicinski <kuba@kernel.org>
To: Leon Romanovsky <leon@kernel.org>
Cc: Vadim Fedorenko <vadim.fedorenko@linux.dev>,
Andrew Lunn <andrew@lunn.ch>, Bjorn Helgaas <helgaas@kernel.org>,
Sanman Pradhan <sanman.p211993@gmail.com>,
Bjorn Helgaas <bhelgaas@google.com>,
netdev@vger.kernel.org, alexanderduyck@fb.com,
kernel-team@meta.com, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, horms@kernel.org, corbet@lwn.net,
mohsin.bashr@gmail.com, sanmanpradhan@meta.com,
andrew+netdev@lunn.ch, jdamato@fastly.com, sdf@fomichev.me,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-pci@vger.kernel.org
Subject: Re: [PATCH net-next] eth: fbnic: Add PCIe hardware statistics
Date: Thu, 7 Nov 2024 07:40:09 -0800 [thread overview]
Message-ID: <20241107074009.5712809a@kernel.org> (raw)
In-Reply-To: <20241107120357.GL5006@unreal>
On Thu, 7 Nov 2024 14:03:57 +0200 Leon Romanovsky wrote:
> > [root@host ~]# ethtool -i eth0 | grep driver
> > driver: mlx5_core
> > [root@host ~]# ethtool -S eth0 | grep pci
> > rx_pci_signal_integrity: 1
> > tx_pci_signal_integrity: 1471
> > outbound_pci_stalled_rd: 0
> > outbound_pci_stalled_wr: 0
> > outbound_pci_stalled_rd_events: 0
> > outbound_pci_stalled_wr_events: 0
> >
> > Isn't it a PCIe statistics?
>
> I didn't do full archaeological research and stopped at 2017 there these
> counters were updated to use new API, but it looks like they there from
> stone age.
>
> It was a mistake to put it there and they should be moved to PCI core
> together with other hundreds debug counters which ConnectX devices have
> but don't expose yet.
Whatever hand-waving you do now, it's impossible to take you seriously
where the device driver of which you are a maintainer does the same
thing. And your direction going forward for PCIe debug, AFAIU, is the
proprietary fwctl stuff. Please stop.
next prev parent reply other threads:[~2024-11-07 15:40 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-06 0:26 [PATCH net-next] eth: fbnic: Add PCIe hardware statistics Sanman Pradhan
2024-11-06 0:43 ` Jakub Kicinski
2024-11-06 0:49 ` Joe Damato
2024-11-07 2:14 ` Sanman Pradhan
2024-11-06 12:22 ` Leon Romanovsky
2024-11-06 17:12 ` Bjorn Helgaas
2024-11-06 17:36 ` Andrew Lunn
2024-11-07 0:09 ` Jakub Kicinski
2024-11-07 8:23 ` Leon Romanovsky
2024-11-07 11:30 ` Vadim Fedorenko
2024-11-07 12:03 ` Leon Romanovsky
2024-11-07 15:40 ` Jakub Kicinski [this message]
2024-11-07 16:42 ` Leon Romanovsky
2024-11-06 17:50 ` Leon Romanovsky
2024-11-06 21:17 ` Bjorn Helgaas
2024-11-07 8:11 ` Leon Romanovsky
2024-11-06 17:32 ` Andrew Lunn
2024-11-07 2:16 ` Sanman Pradhan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241107074009.5712809a@kernel.org \
--to=kuba@kernel.org \
--cc=alexanderduyck@fb.com \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@lunn.ch \
--cc=bhelgaas@google.com \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=helgaas@kernel.org \
--cc=horms@kernel.org \
--cc=jdamato@fastly.com \
--cc=kernel-team@meta.com \
--cc=leon@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mohsin.bashr@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sanman.p211993@gmail.com \
--cc=sanmanpradhan@meta.com \
--cc=sdf@fomichev.me \
--cc=vadim.fedorenko@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).