From: Bharat Bhushan <bbhushan2@marvell.com>
To: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<sgoutham@marvell.com>, <gakula@marvell.com>,
<sbhatta@marvell.com>, <hkelam@marvell.com>,
<davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
<pabeni@redhat.com>, <jerinj@marvell.com>, <lcherian@marvell.com>,
<ndabilpuram@marvell.com>, <sd@queasysnail.net>,
<bbhushan2@marvell.com>
Subject: [net-next PATCH v9 1/8] octeontx2-pf: map skb data as device writeable
Date: Fri, 8 Nov 2024 10:27:01 +0530 [thread overview]
Message-ID: <20241108045708.1205994-2-bbhushan2@marvell.com> (raw)
In-Reply-To: <20241108045708.1205994-1-bbhushan2@marvell.com>
Crypto hardware need write permission for in-place encrypt
or decrypt operation on skb-data to support IPsec crypto
offload. That patch uses skb_unshare to make skb data writeable
for ipsec crypto offload and map skb fragment memory as
device read-write.
Signed-off-by: Bharat Bhushan <bbhushan2@marvell.com>
---
v7->v8:
- spell correction (s/sdk/skb) in description
v6->v7:
- skb data was mapped as device writeable but it was not ensured
that skb is writeable. This version calls skb_unshare() to make
skb data writeable.
.../ethernet/marvell/octeontx2/nic/otx2_txrx.c | 18 ++++++++++++++++--
1 file changed, 16 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_txrx.c b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_txrx.c
index 7aaf32e9aa95..49b6b091ba41 100644
--- a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_txrx.c
+++ b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_txrx.c
@@ -11,6 +11,7 @@
#include <linux/bpf.h>
#include <linux/bpf_trace.h>
#include <net/ip6_checksum.h>
+#include <net/xfrm.h>
#include "otx2_reg.h"
#include "otx2_common.h"
@@ -83,10 +84,17 @@ static unsigned int frag_num(unsigned int i)
static dma_addr_t otx2_dma_map_skb_frag(struct otx2_nic *pfvf,
struct sk_buff *skb, int seg, int *len)
{
+ enum dma_data_direction dir = DMA_TO_DEVICE;
const skb_frag_t *frag;
struct page *page;
int offset;
+ /* Crypto hardware need write permission for ipsec crypto offload */
+ if (unlikely(xfrm_offload(skb))) {
+ dir = DMA_BIDIRECTIONAL;
+ skb = skb_unshare(skb, GFP_ATOMIC);
+ }
+
/* First segment is always skb->data */
if (!seg) {
page = virt_to_page(skb->data);
@@ -98,16 +106,22 @@ static dma_addr_t otx2_dma_map_skb_frag(struct otx2_nic *pfvf,
offset = skb_frag_off(frag);
*len = skb_frag_size(frag);
}
- return otx2_dma_map_page(pfvf, page, offset, *len, DMA_TO_DEVICE);
+ return otx2_dma_map_page(pfvf, page, offset, *len, dir);
}
static void otx2_dma_unmap_skb_frags(struct otx2_nic *pfvf, struct sg_list *sg)
{
+ enum dma_data_direction dir = DMA_TO_DEVICE;
+ struct sk_buff *skb = NULL;
int seg;
+ skb = (struct sk_buff *)sg->skb;
+ if (unlikely(xfrm_offload(skb)))
+ dir = DMA_BIDIRECTIONAL;
+
for (seg = 0; seg < sg->num_segs; seg++) {
otx2_dma_unmap_page(pfvf, sg->dma_addr[seg],
- sg->size[seg], DMA_TO_DEVICE);
+ sg->size[seg], dir);
}
sg->num_segs = 0;
}
--
2.34.1
next prev parent reply other threads:[~2024-11-08 4:57 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-08 4:57 [net-next PATCH v9 0/8] cn10k-ipsec: Add outbound inline ipsec support Bharat Bhushan
2024-11-08 4:57 ` Bharat Bhushan [this message]
2024-11-10 14:23 ` [net-next PATCH v9 1/8] octeontx2-pf: map skb data as device writeable Leon Romanovsky
2024-11-11 5:01 ` Bharat Bhushan
2024-11-11 7:15 ` Leon Romanovsky
2024-11-11 8:50 ` Bharat Bhushan
2024-11-08 4:57 ` [net-next PATCH v9 2/8] octeontx2-pf: Move skb fragment map/unmap to common code Bharat Bhushan
2024-11-08 4:57 ` [net-next PATCH v9 3/8] octeontx2-af: Disable backpressure between CPT and NIX Bharat Bhushan
2024-11-08 4:57 ` [net-next PATCH v9 4/8] cn10k-ipsec: Init hardware for outbound ipsec crypto offload Bharat Bhushan
2024-11-08 4:57 ` [net-next PATCH v9 5/8] cn10k-ipsec: Add SA add/del support for outb " Bharat Bhushan
2024-11-12 12:41 ` Paolo Abeni
2024-11-15 10:13 ` Bharat Bhushan
2024-11-08 4:57 ` [net-next PATCH v9 6/8] cn10k-ipsec: Process outbound " Bharat Bhushan
2024-11-12 12:48 ` Paolo Abeni
2024-11-15 10:16 ` Bharat Bhushan
2024-11-08 4:57 ` [net-next PATCH v9 7/8] cn10k-ipsec: Allow ipsec crypto offload for skb with SA Bharat Bhushan
2024-11-08 4:57 ` [net-next PATCH v9 8/8] cn10k-ipsec: Enable outbound ipsec crypto offload Bharat Bhushan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241108045708.1205994-2-bbhushan2@marvell.com \
--to=bbhushan2@marvell.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gakula@marvell.com \
--cc=hkelam@marvell.com \
--cc=jerinj@marvell.com \
--cc=kuba@kernel.org \
--cc=lcherian@marvell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ndabilpuram@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sbhatta@marvell.com \
--cc=sd@queasysnail.net \
--cc=sgoutham@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).