From: Simon Horman <horms@kernel.org>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: Realtek linux nic maintainers <nic_swsd@realtek.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
Paolo Abeni <pabeni@redhat.com>, Jakub Kicinski <kuba@kernel.org>,
David Miller <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next 1/3] r8169: improve __rtl8169_set_wol
Date: Fri, 8 Nov 2024 19:43:17 +0000 [thread overview]
Message-ID: <20241108194317.GF4507@kernel.org> (raw)
In-Reply-To: <697b197a-8eac-40c6-8847-27093cacec36@gmail.com>
On Wed, Nov 06, 2024 at 05:55:45PM +0100, Heiner Kallweit wrote:
> Add helper r8169_mod_reg8_cond() what allows to significantly simplify
> __rtl8169_set_wol().
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
__rtl8169_set_wol() certainly is much nicer now.
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2024-11-08 19:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-06 16:54 [PATCH net-next 0/3] r8169: improve wol/suspend-related code Heiner Kallweit
2024-11-06 16:55 ` [PATCH net-next 1/3] r8169: improve __rtl8169_set_wol Heiner Kallweit
2024-11-08 19:43 ` Simon Horman [this message]
2024-11-06 16:56 ` [PATCH net-next 2/3] r8169: improve rtl_set_d3_pll_down Heiner Kallweit
2024-11-08 19:43 ` Simon Horman
2024-11-06 16:57 ` [PATCH net-next 3/3] r8169: align WAKE_PHY handling with r8125/r8126 vendor drivers Heiner Kallweit
2024-11-08 19:43 ` Simon Horman
2024-11-09 21:50 ` [PATCH net-next 0/3] r8169: improve wol/suspend-related code patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241108194317.GF4507@kernel.org \
--to=horms@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).