From: Jakub Kicinski <kuba@kernel.org>
To: Sanman Pradhan <sanman.p211993@gmail.com>
Cc: netdev@vger.kernel.org, alexanderduyck@fb.com,
kernel-team@meta.com, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, horms@kernel.org, corbet@lwn.net,
mohsin.bashr@gmail.com, sanmanpradhan@meta.com,
andrew+netdev@lunn.ch, vadim.fedorenko@linux.dev,
jdamato@fastly.com, sdf@fomichev.me, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v4] eth: fbnic: Add PCIe hardware statistics
Date: Fri, 8 Nov 2024 19:57:36 -0800 [thread overview]
Message-ID: <20241108195736.7b189843@kernel.org> (raw)
In-Reply-To: <20241109025905.1531196-1-sanman.p211993@gmail.com>
On Fri, 8 Nov 2024 18:59:05 -0800 Sanman Pradhan wrote:
> v4:
> - Fix indentations
> - Adding missing updates for previous versions
Please don't post multiple versions a day, per:
https://www.kernel.org/doc/html/next/process/maintainer-netdev.html#tl-dr
> .../device_drivers/ethernet/meta/fbnic.rst | 26 ++++
> drivers/net/ethernet/meta/fbnic/fbnic_csr.h | 37 ++++++
> .../net/ethernet/meta/fbnic/fbnic_debugfs.c | 54 +++++++++
> .../net/ethernet/meta/fbnic/fbnic_hw_stats.c | 114 ++++++++++++++++++
> .../net/ethernet/meta/fbnic/fbnic_hw_stats.h | 12 ++
> .../net/ethernet/meta/fbnic/fbnic_netdev.c | 3 +
> 6 files changed, 246 insertions(+)
> create mode 100644 drivers/net/ethernet/meta/fbnic/fbnic_debugfs.c
I just realized that you couldn't have tested this patch properly
because you added a file, did not include it in the Makefile, and
yet the build doesn't break. So you must be calling neither
fbnic_dbg_init() nor fbnic_dbg_exit().
Not great.
--
pw-bot: cr
next prev parent reply other threads:[~2024-11-09 3:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-09 2:59 [PATCH net-next v4] eth: fbnic: Add PCIe hardware statistics Sanman Pradhan
2024-11-09 3:57 ` Jakub Kicinski [this message]
2024-11-11 19:57 ` Sanman Pradhan
2024-11-09 18:00 ` Andrew Lunn
2024-11-11 19:57 ` Sanman Pradhan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241108195736.7b189843@kernel.org \
--to=kuba@kernel.org \
--cc=alexanderduyck@fb.com \
--cc=andrew+netdev@lunn.ch \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jdamato@fastly.com \
--cc=kernel-team@meta.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mohsin.bashr@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sanman.p211993@gmail.com \
--cc=sanmanpradhan@meta.com \
--cc=sdf@fomichev.me \
--cc=vadim.fedorenko@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).