From: vtpieter@gmail.com
To: tharvey@gateworks.com, o.rempel@pengutronix.de, pabeni@redhat.com
Cc: UNGLinuxDriver@microchip.com, andrew@lunn.ch,
davem@davemloft.net, edumazet@google.com, f.fainelli@gmail.com,
kuba@kernel.org, linux-kernel@vger.kernel.org, lukma@denx.de,
netdev@vger.kernel.org, olteanv@gmail.com,
woojung.huh@microchip.com,
Pieter Van Trappen <pieter.van.trappen@cern.ch>
Subject: [PATCH net v4] net: dsa: microchip: disable EEE for KSZ879x/KSZ877x/KSZ876x
Date: Fri, 8 Nov 2024 22:48:15 +0100 [thread overview]
Message-ID: <20241108214815.3874964-1-vtpieter@gmail.com> (raw)
In-Reply-To: <20241018160658.781564-1-tharvey@gateworks.com>
From: Pieter Van Trappen <pieter.van.trappen@cern.ch>
Hi Tim, all,
Sorry I'm a bit late to the party but I think this patch is not doing
much since most if not all KSZ8 switches don't have MMD
registers. They do have EEE registers but these require indirect
access that's not compatible with PHY MMD (indirect) registers as far
as I understand. So your patch does no harm but is not doing anything
useful either I reckon.
For the KSZ8 devices, the EEE errata is handled from the DSA switch
driver ksz8.c, ksz8_handle_global_errata.
Cheers, Pieter
prev parent reply other threads:[~2024-11-08 21:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-18 16:06 [PATCH net v4] net: dsa: microchip: disable EEE for KSZ879x/KSZ877x/KSZ876x Tim Harvey
2024-10-20 8:44 ` Oleksij Rempel
2024-10-24 10:50 ` patchwork-bot+netdevbpf
2024-11-08 21:48 ` vtpieter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241108214815.3874964-1-vtpieter@gmail.com \
--to=vtpieter@gmail.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukma@denx.de \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=pieter.van.trappen@cern.ch \
--cc=tharvey@gateworks.com \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).