From: Jakub Kicinski <kuba@kernel.org>
To: Edward Cree <ecree.xilinx@gmail.com>
Cc: Joe Damato <jdamato@fastly.com>, Daniel Xu <dxu@dxuuu.xyz>,
davem@davemloft.net, mkubecek@suse.cz, martin.lau@linux.dev,
netdev@vger.kernel.org, kernel-team@meta.com
Subject: Re: [PATCH ethtool-next] rxclass: Make output for RSS context action explicit
Date: Sat, 9 Nov 2024 09:42:09 -0800 [thread overview]
Message-ID: <20241109094209.7e2e63db@kernel.org> (raw)
In-Reply-To: <58302551-352b-2d9e-1914-b9032942cfa3@gmail.com>
On Fri, 8 Nov 2024 21:13:50 +0000 Edward Cree wrote:
> I think sensible output would be to keep Daniel's "Action: Direct to
> RSS context id %u", but also print something like "Queue base offset:
> %u" with the ring index that was previously printed as the Action.
> If the base offset is zero its output could possibly be suppressed.
> And we should update the ethtool man page to describe the adding
> behaviour, and audit device drivers to ensure that any that don't
> support it reject RSS filters with nonzero ring_cookie, as specified
> in [1].
> Does this sound reasonable?
I'd suggest we merge Daniel's patch (almost) as is, and you can
(re)establish the behavior sfc wants but you owe us:
- fixes for helpers used in "is the queue in use" checks like
ethtool_get_max_rss_ctx_channel()
- "opt in" flag for drivers which actually support this rather
than silently ignoring ring_cookie if rss ctx is set
- selftest
:(
next prev parent reply other threads:[~2024-11-09 17:42 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-08 19:32 [PATCH ethtool-next] rxclass: Make output for RSS context action explicit Daniel Xu
2024-11-08 19:35 ` Daniel Xu
2024-11-08 19:56 ` Edward Cree
2024-11-08 20:34 ` Joe Damato
2024-11-08 20:43 ` Joe Damato
2024-11-08 21:13 ` Edward Cree
2024-11-08 22:50 ` Daniel Xu
2024-11-09 17:42 ` Jakub Kicinski [this message]
2024-11-11 10:47 ` Edward Cree
2024-11-11 18:22 ` Jakub Kicinski
2024-11-12 9:24 ` Edward Cree
2024-11-12 15:24 ` Jakub Kicinski
2024-11-13 3:30 ` Edward Cree
2024-11-14 0:46 ` Jakub Kicinski
2024-11-14 0:46 ` Jakub Kicinski
2024-11-14 23:04 ` Edward Cree
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241109094209.7e2e63db@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=dxu@dxuuu.xyz \
--cc=ecree.xilinx@gmail.com \
--cc=jdamato@fastly.com \
--cc=kernel-team@meta.com \
--cc=martin.lau@linux.dev \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).