From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B8C01611E; Sun, 10 Nov 2024 00:59:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731200349; cv=none; b=Sj+nU+UWogSsth4aG2UtGqE8gfU8GGJ0aoQYZuWfYnvBPzYnVIudSBG7rKDIO4o6L7IxPvCEMlmlZOeVjnDySWRGYP29CkTXzRPATj7tfXyM8g8F5go5mOOOIfEJrW1bdMMaOXzjsUghzoV1VkTAB6LV/P9Yo20EQxxsAdQ/7I4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731200349; c=relaxed/simple; bh=eI4NrvYWCzY8jT56L2G03qeev6Tssv52JXBZuJzg/m8=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=rTSy35RP0SeDvWZ5HpC069jtJpn9Q3Q+MyHfMDiPLwDnoohYbROlw+Cs8+NoljILYMAV9JBpNq+rpDcxePLTMTmiuK+mOhr3/i1zM+rYcmgXvRzgi2LgbT7F943DAQbLZQyn+ezmaOf2grX/GXBICO+aIrH3Jz0woLGhfOOiblU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=cyeXHKam; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="cyeXHKam" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 69E51C4CECE; Sun, 10 Nov 2024 00:59:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1731200349; bh=eI4NrvYWCzY8jT56L2G03qeev6Tssv52JXBZuJzg/m8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=cyeXHKamel7zxzso4MJjVcv5eVvRG2B/Z+PAXKIuoeqd8cQKPbFUatKQdtBBN8ePO Ch3nVHLWTJVy9rRxVS1Iibvg4COShjE4vGJr6V68GXs7gy5S0ifjmSJdCGizq2kuFb v/Xm5NWRNKPpQxSAI2uCFckuNdpJ2Ekf+erwEnoD+SvnY+8aoyVissres+tMpz+uC8 5+lzgXKHxlfHWBeHEEsU01zCfKGt7pHd4Kt8LYnLOg1bcuLgvFFTtxO7JzFMiRZFl5 tezmonZUao18zfVxkxBfie8praEh9a9vZ3wO/NAlxeGb1ssbenBSXhegPwTiQLUG77 w64VUKdFeZCfw== Date: Sat, 9 Nov 2024 16:59:07 -0800 From: Jakub Kicinski To: Xiao Liang Cc: Eric Dumazet , netdev@vger.kernel.org, linux-kselftest@vger.kernel.org, Kuniyuki Iwashima , "David S. Miller" , David Ahern , Paolo Abeni , Ido Schimmel , Andrew Lunn , Simon Horman , Donald Hunter , Shuah Khan , Jiri Pirko , Hangbin Liu Subject: Re: [PATCH net-next v2 5/8] net: ip_gre: Add netns_atomic module parameter Message-ID: <20241109165907.4e9611a9@kernel.org> In-Reply-To: References: <20241107133004.7469-1-shaw.leon@gmail.com> <20241107133004.7469-6-shaw.leon@gmail.com> <20241107075943.78bb160c@kernel.org> <20241107200410.4126cf52@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Fri, 8 Nov 2024 14:44:37 +0800 Xiao Liang wrote: > > On Fri, 8 Nov 2024 00:53:55 +0800 Xiao Liang wrote: > > > IMO, this is about driver capability, not about user requests. > > > > The bit is a driver capability, that's fine. But the question was how > > to achieve backward compatibility. A flag in user request shifts the > > responsibility of ensuring all services are compatible to whoever > > spawns the interfaces. Which will probably be some network management > > daemon. > > OK. So I think we can change the driver capability indicator in rtnl_ops > to a tristate field, say, "linkns_support". > If it is > - not supported, then keep the old behavior > - supported (vlan, macvlan, etc.), then change to the new behavior > - compat-mode (ip_tunnel), default to old behavior and can be changed > via an IFLA flag. > Is this reasonable? Let's start with annotating the drivers which need the old behavior. It seems like something that was done as a workaround for old drivers, maybe there isn't that many of them and we can convert them all in one series.