From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 371D88467;
	Sun, 10 Nov 2024 01:01:04 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1731200465; cv=none; b=UtmVsKOGzaR86qgPqzcpybZfJ44otIUACFFU/Mdggsgky0u196Jpe3YD+qHAZMmRrCqgpTKEN2K3zW1aBLl+yy/l/KjHkB0jM2kwVmF2XPs8YRauHuvHMutuw5SIgnCGC6YOB+3TXd8i7LGKn2TSbWtX7OTFUmR/68bTr6DeHIg=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1731200465; c=relaxed/simple;
	bh=7HKtwwcNDuHyWBQkDPgYk+fRJVp28ag6MsjSZN3baY4=;
	h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References:
	 MIME-Version:Content-Type; b=ABZZQva3+2BcL5vFyHm/jK7DKe9eavkFL60IebtIivv2FegFV8gukDSQwfDaiZJbaBtweKFWY9TwRMIBwr5foely3SWGBMl05eK/eQ+pw3nW0RSK3t4E7DHtiDULSCiUSMKfjxatoyn87/2nvBESNJH+8EQpdWHveoYaB1gmhFU=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=rLaDNbyo; arc=none smtp.client-ip=10.30.226.201
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="rLaDNbyo"
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2490DC4CECE;
	Sun, 10 Nov 2024 01:01:04 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1731200464;
	bh=7HKtwwcNDuHyWBQkDPgYk+fRJVp28ag6MsjSZN3baY4=;
	h=Date:From:To:Cc:Subject:In-Reply-To:References:From;
	b=rLaDNbyobtSxzKQF46JnYNXsJh2+IMhMi823WT5S+iiopufcF1d1P2RXd0WFDSGuM
	 SzUD+IDN1lHOq1YbrefvLDXuu06sbxxQIee18ucBG9b1TKNtNlHDtcI9LvsTMp1k3T
	 EosVzZB3tB4wBNLmwrszbM8F0TV3IvNYMGe+pE7WcnN9VxFgmH4sI1o7Z00TVdNS7A
	 YE0VDLVKJbLeWAUVZr+fbN8xY4l12Cl2XmQ+a2opbc8e6at8vtk9FPnDBCR1c/2S4g
	 0lWJYE61WYkfs4sslYYCQET/gOm4lOVxkHBSjwieW1ecUs8z2LJ9HX/9VSYDPbBD2R
	 GeLgSJCRQgAvw==
Date: Sat, 9 Nov 2024 17:01:02 -0800
From: Jakub Kicinski <kuba@kernel.org>
To: Xiao Liang <shaw.leon@gmail.com>
Cc: netdev@vger.kernel.org, linux-kselftest@vger.kernel.org, Kuniyuki
 Iwashima <kuniyu@amazon.com>, "David S. Miller" <davem@davemloft.net>,
 David Ahern <dsahern@kernel.org>, Eric Dumazet <edumazet@google.com>, Paolo
 Abeni <pabeni@redhat.com>, Ido Schimmel <idosch@nvidia.com>, Andrew Lunn
 <andrew+netdev@lunn.ch>, Simon Horman <horms@kernel.org>, Donald Hunter
 <donald.hunter@gmail.com>, Shuah Khan <shuah@kernel.org>, Jiri Pirko
 <jiri@resnulli.us>, Hangbin Liu <liuhangbin@gmail.com>
Subject: Re: [PATCH net-next v2 8/8] selftests: net: Add two test cases for
 link netns
Message-ID: <20241109170102.05a5c3f7@kernel.org>
In-Reply-To: <20241107133004.7469-9-shaw.leon@gmail.com>
References: <20241107133004.7469-1-shaw.leon@gmail.com>
	<20241107133004.7469-9-shaw.leon@gmail.com>
Precedence: bulk
X-Mailing-List: netdev@vger.kernel.org
List-Id: <netdev.vger.kernel.org>
List-Subscribe: <mailto:netdev+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:netdev+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Thu,  7 Nov 2024 21:30:03 +0800 Xiao Liang wrote:
> +class NSEnter:
> +    def __init__(self, ns_name):
> +        self.ns_path = f"/run/netns/{ns_name}"
> +
> +    def __enter__(self):
> +        self.saved = open("/proc/thread-self/ns/net")
> +        with open(self.ns_path) as ns_file:
> +            libc.setns(ns_file.fileno(), 0)
> +
> +    def __exit__(self, exc_type, exc_value, traceback):
> +        libc.setns(self.saved.fileno(), 0)
> +        self.saved.close()

This is quite nice, why not move it to
tools/testing/selftests/net/lib/py/netns.py
so others can use it too