From: Simon Horman <horms@kernel.org>
To: Shinas Rasheed <srasheed@marvell.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
hgani@marvell.com, sedara@marvell.com, vimleshk@marvell.com,
thaller@redhat.com, wizhao@redhat.com, kheib@redhat.com,
egallen@redhat.com, konguyen@redhat.com, frank.feng@synaxg.com,
Veerasenareddy Burru <vburru@marvell.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Subject: Re: [PATCH net-next] octeon_ep: add ndo ops for VFs in PF driver
Date: Sun, 10 Nov 2024 13:18:46 +0000 [thread overview]
Message-ID: <20241110131846.GL4507@kernel.org> (raw)
In-Reply-To: <20241107121637.1117089-1-srasheed@marvell.com>
On Thu, Nov 07, 2024 at 04:16:37AM -0800, Shinas Rasheed wrote:
> These APIs are needed to support applicaitons that use netlink to get VF
> information from a PF driver.
>
> Signed-off-by: Shinas Rasheed <srasheed@marvell.com>
...
> +static int octep_set_vf_vlan(struct net_device *dev, int vf, u16 vlan, u8 qos, __be16 vlan_proto)
> +{
> + struct octep_device *oct = netdev_priv(dev);
> +
> + dev_err(&oct->pdev->dev, "Setting VF VLAN not supported\n");
> + return 0;
> +}
Hi Shinas,
Given that the operation is not supported I think it would
be more appropriate to return -EOPNOTSUPP. And moreover, given
that this is a noop, I think it would be yet more appropriate
not to implement it at all and let the core treat it as not supported.
Likewise for other NDOs implemented as noops in this patch.
...
next prev parent reply other threads:[~2024-11-10 13:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-07 12:16 [PATCH net-next] octeon_ep: add ndo ops for VFs in PF driver Shinas Rasheed
2024-11-10 13:18 ` Simon Horman [this message]
2024-11-11 5:29 ` [EXTERNAL] " Shinas Rasheed
2024-11-12 14:12 ` Simon Horman
2024-11-11 6:08 ` Kalesh Anakkur Purayil
2024-11-12 18:30 ` [EXTERNAL] " Shinas Rasheed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241110131846.GL4507@kernel.org \
--to=horms@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=egallen@redhat.com \
--cc=frank.feng@synaxg.com \
--cc=hgani@marvell.com \
--cc=kheib@redhat.com \
--cc=konguyen@redhat.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sedara@marvell.com \
--cc=srasheed@marvell.com \
--cc=thaller@redhat.com \
--cc=vburru@marvell.com \
--cc=vimleshk@marvell.com \
--cc=wizhao@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).