* [PATCH net] gve: Flow steering trigger reset only for timeout error
@ 2024-11-07 18:34 Jeroen de Borst
2024-11-10 14:43 ` Simon Horman
0 siblings, 1 reply; 2+ messages in thread
From: Jeroen de Borst @ 2024-11-07 18:34 UTC (permalink / raw)
To: netdev
Cc: davem, edumazet, kuba, stable, pabeni, jeroendb, pkaligineedi,
shailend, andrew+netdev, willemb, hramamurthy, ziweixiao
From: Ziwei Xiao <ziweixiao@google.com>
When configuring flow steering rules, the driver is currently going
through a reset for all errors from the device. Instead, the driver
should only reset when there's a timeout error from the device.
Fixes: 57718b60df9b ("gve: Add flow steering adminq commands")
Cc: stable@vger.kernel.org
Signed-off-by: Ziwei Xiao <ziweixiao@google.com>
Reviewed-by: Harshitha Ramamurthy <hramamurthy@google.com>
---
drivers/net/ethernet/google/gve/gve_adminq.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/google/gve/gve_adminq.c b/drivers/net/ethernet/google/gve/gve_adminq.c
index e44e8b139633..060e0e674938 100644
--- a/drivers/net/ethernet/google/gve/gve_adminq.c
+++ b/drivers/net/ethernet/google/gve/gve_adminq.c
@@ -1248,10 +1248,10 @@ gve_adminq_configure_flow_rule(struct gve_priv *priv,
sizeof(struct gve_adminq_configure_flow_rule),
flow_rule_cmd);
- if (err) {
+ if (err == -ETIME) {
dev_err(&priv->pdev->dev, "Timeout to configure the flow rule, trigger reset");
gve_reset(priv, true);
- } else {
+ } else if (!err) {
priv->flow_rules_cache.rules_cache_synced = false;
}
--
2.47.0.277.g8800431eea-goog
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH net] gve: Flow steering trigger reset only for timeout error
2024-11-07 18:34 [PATCH net] gve: Flow steering trigger reset only for timeout error Jeroen de Borst
@ 2024-11-10 14:43 ` Simon Horman
0 siblings, 0 replies; 2+ messages in thread
From: Simon Horman @ 2024-11-10 14:43 UTC (permalink / raw)
To: Jeroen de Borst
Cc: netdev, davem, edumazet, kuba, stable, pabeni, pkaligineedi,
shailend, andrew+netdev, willemb, hramamurthy, ziweixiao
On Thu, Nov 07, 2024 at 10:34:31AM -0800, Jeroen de Borst wrote:
> From: Ziwei Xiao <ziweixiao@google.com>
>
> When configuring flow steering rules, the driver is currently going
> through a reset for all errors from the device. Instead, the driver
> should only reset when there's a timeout error from the device.
>
> Fixes: 57718b60df9b ("gve: Add flow steering adminq commands")
> Cc: stable@vger.kernel.org
> Signed-off-by: Ziwei Xiao <ziweixiao@google.com>
> Reviewed-by: Harshitha Ramamurthy <hramamurthy@google.com>
Hi Jeroen,
As you are posting this patch your Signed-off-by line needs to go here.
--
pw-bot: changes-requested
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-11-10 14:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-11-07 18:34 [PATCH net] gve: Flow steering trigger reset only for timeout error Jeroen de Borst
2024-11-10 14:43 ` Simon Horman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).