From: Jakub Kicinski <kuba@kernel.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
"Johannes Berg" <johannes.berg@intel.com>,
"Toke Høiland-Jørgensen" <toke@kernel.org>
Subject: Re: [PATCH net-next v3 1/2] net: netlink: add nla_get_*_default() accessors
Date: Mon, 11 Nov 2024 10:39:10 -0800 [thread overview]
Message-ID: <20241111103910.37379ad8@kernel.org> (raw)
In-Reply-To: <20241108114145.acd2aadb03ac.I3df6aac71d38a5baa1c0a03d0c7e82d4395c030e@changeid>
On Fri, 8 Nov 2024 11:41:44 +0100 Johannes Berg wrote:
> From: Johannes Berg <johannes.berg@intel.com>
>
> There are quite a number of places that use patterns
> such as
>
> if (attr)
> val = nla_get_u16(attr);
> else
> val = DEFAULT;
>
> Add nla_get_u16_default() and friends like that to
> not have to type this out all the time.
>
> Acked-by: Toke Høiland-Jørgensen <toke@kernel.org>
> Acked-by: Jakub Kicinski <kuba@kernel.org>
> Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Applied with some minor whitespace fixes, thanks!
prev parent reply other threads:[~2024-11-11 18:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-08 10:41 [PATCH net-next v3 1/2] net: netlink: add nla_get_*_default() accessors Johannes Berg
2024-11-08 10:41 ` [PATCH net-next v3 2/2] net: convert to nla_get_*_default() Johannes Berg
2024-11-08 20:25 ` Toke Høiland-Jørgensen
2024-11-11 18:39 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241111103910.37379ad8@kernel.org \
--to=kuba@kernel.org \
--cc=johannes.berg@intel.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=toke@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).