From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5B8B91A2567; Mon, 11 Nov 2024 18:39:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731350352; cv=none; b=DiVaqxH6oJdx3Y++AHnyQAMzR5V3dsL63om9LFW6l2ZgRqEvZNeJMSwdAQqgSQRCDvhbkokB2YR4KpUgvqKlKsoTIkVawOOOLZF2WBlfg1sqTdlwq0jthVvNNcrWWNot4gkw8fYqCToBACw0fdE6vrDlvN5WPvqv6dnFFXStgGE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731350352; c=relaxed/simple; bh=m6RnQzTjzeLUIXctOT39qWK9ZuWdkcil+4kDnLcEvaA=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=GtydbuYMO9z69yGdxTQ6iplKuNVFG5VpCYCxZyUb4aCALLROW4DiKA0IzzEcwtC0YAP6Q747nCLAguFm8e9h4xIen3LP3IEsoVlzwb0EJqgQNZkNoYHZF3kgpdcZmx9gVkw0lHHN72cZTS0sWRnnQwlHOtLaWMYql5U4kjEXeF0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=NGZ1QO1Z; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="NGZ1QO1Z" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8FF48C4CECF; Mon, 11 Nov 2024 18:39:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1731350351; bh=m6RnQzTjzeLUIXctOT39qWK9ZuWdkcil+4kDnLcEvaA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=NGZ1QO1Z1Yk0jLMwzf3eIUBvbbWykGkvS1pafgtJ5lcLQEaVYzXgloz8wJDtc/BTK OU+bgWyF61hV7ZfmmGvEp6n1Hpu/xAeLxt1aKMTo2tkLtBBj1pcEvS+0nolw6pEUoK 1HMnhwcy/Ynhq1uZ0cY0c43eoCNn9nZcZgTTWQ1dbxqCnq3bhIJljY2489njK0c8Yp ni1zUyoZNs+KqYIz64kJGUGzb0uni27lf5ugwa5o16lnMbkUyOI1uigdK6d6U7T5Zc r3RwlJYP1FrpexTJNCxkNHJOIRX/3j8brYDaZpxfQYdj95837uZ1kgTAy6QPGr4HX4 w6hDXbgREsX4Q== Date: Mon, 11 Nov 2024 10:39:10 -0800 From: Jakub Kicinski To: Johannes Berg Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org, Johannes Berg , Toke =?UTF-8?B?SMO4aWxhbmQtSsO4cmdlbnNlbg==?= Subject: Re: [PATCH net-next v3 1/2] net: netlink: add nla_get_*_default() accessors Message-ID: <20241111103910.37379ad8@kernel.org> In-Reply-To: <20241108114145.acd2aadb03ac.I3df6aac71d38a5baa1c0a03d0c7e82d4395c030e@changeid> References: <20241108114145.acd2aadb03ac.I3df6aac71d38a5baa1c0a03d0c7e82d4395c030e@changeid> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Fri, 8 Nov 2024 11:41:44 +0100 Johannes Berg wrote: > From: Johannes Berg >=20 > There are quite a number of places that use patterns > such as >=20 > if (attr) > val =3D nla_get_u16(attr); > else > val =3D DEFAULT; >=20 > Add nla_get_u16_default() and friends like that to > not have to type this out all the time. >=20 > Acked-by: Toke H=C3=B8iland-J=C3=B8rgensen > Acked-by: Jakub Kicinski > Signed-off-by: Johannes Berg Applied with some minor whitespace fixes, thanks!