From: Jakub Kicinski <kuba@kernel.org>
To: Caleb Sander Mateos <csander@purestorage.com>
Cc: Saeed Mahameed <saeedm@nvidia.com>,
Leon Romanovsky <leon@kernel.org>,
Tariq Toukan <tariqt@nvidia.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Parav Pandit <parav@nvidia.com>,
netdev@vger.kernel.org, linux-rdma@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v4] mlx5/core: Schedule EQ comp tasklet only if necessary
Date: Mon, 11 Nov 2024 14:13:21 -0800 [thread overview]
Message-ID: <20241111141321.0d723c9d@kernel.org> (raw)
In-Reply-To: <20241105204000.1807095-1-csander@purestorage.com>
On Tue, 5 Nov 2024 13:39:59 -0700 Caleb Sander Mateos wrote:
> Currently, the mlx5_eq_comp_int() interrupt handler schedules a tasklet
> to call mlx5_cq_tasklet_cb() if it processes any completions. For CQs
> whose completions don't need to be processed in tasklet context, this
> adds unnecessary overhead. In a heavy TCP workload, we see 4% of CPU
> time spent on the tasklet_trylock() in tasklet_action_common(), with a
> smaller amount spent on the atomic operations in tasklet_schedule(),
> tasklet_clear_sched(), and locking the spinlock in mlx5_cq_tasklet_cb().
> TCP completions are handled by mlx5e_completion_event(), which schedules
> NAPI to poll the queue, so they don't need tasklet processing.
Applied, thanks
prev parent reply other threads:[~2024-11-11 22:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-27 4:06 [PATCH] mlx5: only schedule EQ comp tasklet if necessary Caleb Sander Mateos
2024-10-29 4:08 ` Parav Pandit
2024-10-29 16:32 ` Caleb Sander
2024-10-30 3:16 ` Parav Pandit
2024-10-30 17:06 ` [PATCH v2] " Caleb Sander Mateos
2024-10-31 3:14 ` Parav Pandit
2024-10-31 16:34 ` [PATCH net-next v3] mlx5/core: Schedule EQ comp tasklet only " Caleb Sander Mateos
2024-11-05 12:21 ` Paolo Abeni
2024-11-05 17:28 ` Tariq Toukan
2024-11-05 18:56 ` Saeed Mahameed
2024-11-05 20:39 ` Caleb Sander
2024-11-05 20:39 ` [PATCH net-next v4] " Caleb Sander Mateos
2024-11-11 22:13 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241111141321.0d723c9d@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=csander@purestorage.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=parav@nvidia.com \
--cc=saeedm@nvidia.com \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).