From: Jakub Kicinski <kuba@kernel.org>
To: Caleb Sander Mateos <csander@purestorage.com>
Cc: Saeed Mahameed <saeedm@nvidia.com>,
Leon Romanovsky <leon@kernel.org>,
Tariq Toukan <tariqt@nvidia.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Parav Pandit <parav@nvidia.com>,
netdev@vger.kernel.org, linux-rdma@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2 1/2] mlx5/core: relax memory barrier in eq_update_ci()
Date: Mon, 11 Nov 2024 18:38:14 -0800 [thread overview]
Message-ID: <20241111183814.264205a9@kernel.org> (raw)
In-Reply-To: <20241107183054.2443218-1-csander@purestorage.com>
On Thu, 7 Nov 2024 11:30:51 -0700 Caleb Sander Mateos wrote:
> The memory barrier in eq_update_ci() after the doorbell write is a
> significant hot spot in mlx5_eq_comp_int(). Under heavy TCP load, we see
> 3% of CPU time spent on the mfence instruction.
Applied, thanks.
In the future please avoid sending patches in reply to older version.
prev parent reply other threads:[~2024-11-12 2:38 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-01 3:46 [PATCH net-next 1/2] mlx5/core: avoid memory barrier in eq_update_ci() Caleb Sander Mateos
2024-11-01 3:46 ` [PATCH net-next 2/2] mlx5/core: deduplicate {mlx5_,}eq_update_ci() Caleb Sander Mateos
2024-11-03 3:55 ` Parav Pandit
2024-11-03 22:18 ` Caleb Sander
2024-11-05 5:22 ` Parav Pandit
2024-11-05 16:06 ` Caleb Sander
2024-11-06 5:44 ` Parav Pandit
2024-11-06 23:44 ` Caleb Sander
2024-11-07 2:36 ` Saeed Mahameed
2024-11-07 2:43 ` Parav Pandit
2024-11-07 4:45 ` Caleb Sander
2024-11-07 5:14 ` Saeed Mahameed
2024-11-07 18:30 ` [PATCH net-next v2 1/2] mlx5/core: relax memory barrier in eq_update_ci() Caleb Sander Mateos
2024-11-07 18:30 ` [PATCH net-next v2 2/2] mlx5/core: deduplicate {mlx5_,}eq_update_ci() Caleb Sander Mateos
2024-11-08 10:49 ` Parav Pandit
2024-11-11 11:59 ` Tariq Toukan
2024-11-08 10:46 ` [PATCH net-next v2 1/2] mlx5/core: relax memory barrier in eq_update_ci() Parav Pandit
2024-11-11 11:59 ` Tariq Toukan
2024-11-12 2:38 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241111183814.264205a9@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=csander@purestorage.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=parav@nvidia.com \
--cc=saeedm@nvidia.com \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).