From: Jakub Kicinski <kuba@kernel.org>
To: Rosen Penev <rosenp@gmail.com>
Cc: netdev@vger.kernel.org, Marc Kleine-Budde <mkl@pengutronix.de>,
Vincent Mailhol <mailhol.vincent@wanadoo.fr>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Florian Fainelli <florian.fainelli@broadcom.com>,
Vladimir Oltean <olteanv@gmail.com>, Chen-Yu Tsai <wens@csie.org>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Samuel Holland <samuel@sholland.org>,
Pantelis Antoniou <pantelis.antoniou@gmail.com>,
Marcin Wojtas <marcin.s.wojtas@gmail.com>,
Byungho An <bh74.an@samsung.com>,
Kevin Brace <kevinbrace@bracecomputerlab.com>,
Francois Romieu <romieu@fr.zoreil.com>,
Michal Simek <michal.simek@amd.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
Zhao Qiang <qiang.zhao@nxp.com>,
linux-can@vger.kernel.org (open list:CAN NETWORK DRIVERS),
linux-kernel@vger.kernel.org (open list),
linux-arm-kernel@lists.infradead.org (moderated
list:ARM/Allwinner sunXi SoC support),
linux-sunxi@lists.linux.dev (open list:ARM/Allwinner sunXi SoC
support),
linuxppc-dev@lists.ozlabs.org (open list:FREESCALE SOC FS_ENET
DRIVER)
Subject: Re: [PATCHv2 net-next] net: use pdev instead of OF funcs
Date: Mon, 11 Nov 2024 19:32:22 -0800 [thread overview]
Message-ID: <20241111193222.00ae2f3e@kernel.org> (raw)
In-Reply-To: <20241111210316.15357-1-rosenp@gmail.com>
On Mon, 11 Nov 2024 13:03:16 -0800 Rosen Penev wrote:
> --- a/drivers/net/ethernet/samsung/sxgbe/sxgbe_platform.c
> +++ b/drivers/net/ethernet/samsung/sxgbe/sxgbe_platform.c
> @@ -111,7 +111,7 @@ static int sxgbe_platform_probe(struct platform_device *pdev)
> }
>
> /* Get the SXGBE common INT information */
> - priv->irq = irq_of_parse_and_map(node, 0);
> + priv->irq = platform_get_irq(pdev, 0);
> if (priv->irq <= 0) {
> dev_err(dev, "sxgbe common irq parsing failed\n");
> goto err_drv_remove;
> @@ -122,7 +122,7 @@ static int sxgbe_platform_probe(struct platform_device *pdev)
>
> /* Get the TX/RX IRQ numbers */
> for (i = 0, chan = 1; i < SXGBE_TX_QUEUES; i++) {
> - priv->txq[i]->irq_no = irq_of_parse_and_map(node, chan++);
> + priv->txq[i]->irq_no = platform_get_irq(pdev, chan++);
> if (priv->txq[i]->irq_no <= 0) {
> dev_err(dev, "sxgbe tx irq parsing failed\n");
> goto err_tx_irq_unmap;
> @@ -130,14 +130,14 @@ static int sxgbe_platform_probe(struct platform_device *pdev)
> }
>
> for (i = 0; i < SXGBE_RX_QUEUES; i++) {
> - priv->rxq[i]->irq_no = irq_of_parse_and_map(node, chan++);
> + priv->rxq[i]->irq_no = platform_get_irq(pdev, chan++);
> if (priv->rxq[i]->irq_no <= 0) {
> dev_err(dev, "sxgbe rx irq parsing failed\n");
> goto err_rx_irq_unmap;
> }
> }
>
> - priv->lpi_irq = irq_of_parse_and_map(node, chan);
> + priv->lpi_irq = platform_get_irq(pdev, chan);
> if (priv->lpi_irq <= 0) {
> dev_err(dev, "sxgbe lpi irq parsing failed\n");
> goto err_rx_irq_unmap;
Coccicheck wants you to drop the errors:
drivers/net/ethernet/samsung/sxgbe/sxgbe_platform.c:116:2-9: line 116 is redundant because platform_get_irq() already prints an error
drivers/net/ethernet/samsung/sxgbe/sxgbe_platform.c:127:3-10: line 127 is redundant because platform_get_irq() already prints an error
drivers/net/ethernet/samsung/sxgbe/sxgbe_platform.c:135:3-10: line 135 is redundant because platform_get_irq() already prints an error
drivers/net/ethernet/samsung/sxgbe/sxgbe_platform.c:142:2-9: line 142 is redundant because platform_get_irq() already prints an error
You can make it a separate patch in a series, for clarity.
--
pw-bot: cr
next prev parent reply other threads:[~2024-11-12 3:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-11 21:03 [PATCHv2 net-next] net: use pdev instead of OF funcs Rosen Penev
2024-11-12 3:32 ` Jakub Kicinski [this message]
2024-11-12 4:10 ` Rosen Penev
2024-11-12 7:55 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241111193222.00ae2f3e@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=bh74.an@samsung.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=florian.fainelli@broadcom.com \
--cc=hkallweit1@gmail.com \
--cc=jernej.skrabec@gmail.com \
--cc=kevinbrace@bracecomputerlab.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=linux@armlinux.org.uk \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mailhol.vincent@wanadoo.fr \
--cc=marcin.s.wojtas@gmail.com \
--cc=michal.simek@amd.com \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=pantelis.antoniou@gmail.com \
--cc=qiang.zhao@nxp.com \
--cc=romieu@fr.zoreil.com \
--cc=rosenp@gmail.com \
--cc=samuel@sholland.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).