From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5099A8468; Mon, 11 Nov 2024 20:32:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731357126; cv=none; b=Ku6uV4yRD8+FTFj8JJqiJCWyKRPtoY4QFBpZ84qmqnpeauUN8GIzu56B7B8SCXxLAJCHT+kRmoTIXVD/R6CzxPexV+ardhjdCr27/fGResBO/S/mld+YOGiJQH9OIIKt66KqzT3pUh1WqFxoRU3VAxbTEwe/EcDJUMepvbtKYlc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731357126; c=relaxed/simple; bh=1JKreAiXrQHyGt4F0i/ifIUcZwMi9FkZdg60KkL1b10=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=LpY6TWCm8F9is+wplhr2vWarv/cEEKRoBbnjqgf6Vlm5fS4CBOlQbmv9meyP26GIaRDkG/oYSTW2NTdPIJ5p+EOPuvPhO9mC55ndFdFwZZnFJOqYdbiHT8KFiE+kQ14dOLSQyGj0Zur8ZOATolXvqGb+RKjp+d8iVwSLfwHylAM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=YDqWnnkX; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="YDqWnnkX" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1636DC4CECF; Mon, 11 Nov 2024 20:32:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1731357125; bh=1JKreAiXrQHyGt4F0i/ifIUcZwMi9FkZdg60KkL1b10=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=YDqWnnkXcGVQUzu9ZfIxBV1kHCrZBa2nPgUoEGSNfkjS7+fSm0La7JIWCEl1lYwj5 hjmEBxTZ4QYYIOFJ5Lrd2plVwFtO5rrG/RDcBVI4n9HH9rWvl/vrZAvKzKRQNNIpFR C2/c57j4OTO6JBWbAHnUWmu5B8Mi02SUsw9QnQ2e65wMMfXTLzK5AP05fSDUkNZBe8 hbHjZaLV+K1Tcl21YuElk/zwz0CddvB4ZIOrY87gFSJYTQV5Ht65/e9SJvH3DzFev0 QpjiQ8lrVpcojcTrghkadqaGTjU9roZbwGNxKrsNIH5J3mzvzuEzr3MuOoLasU8tQU K5RJSEU/2SM2w== Date: Mon, 11 Nov 2024 22:31:58 +0200 From: Leon Romanovsky To: Bjorn Helgaas Cc: Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , linux-pci@vger.kernel.org, Ariel Almog , Aditya Prabhune , Hannes Reinecke , Heiner Kallweit , Arun Easi , Jonathan Chocron , Bert Kenward , Matt Carlson , Kai-Heng Feng , Jean Delvare , Alex Williamson , linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH v1 0/2] Fix read permissions for VPD attributes Message-ID: <20241111203158.GC71181@unreal> References: Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Thu, Nov 07, 2024 at 08:56:55PM +0200, Leon Romanovsky wrote: > From: Leon Romanovsky > > Changelog: > v1: > * Changed implementation from open-read-to-everyone to be opt-in > * Removed stable and Fixes tags, as it seems like feature now. > v0: https://lore.kernel.org/all/65791906154e3e5ea12ea49127cf7c707325ca56.1730102428.git.leonro@nvidia.com/ > > -------------------------------------------------------------------------- > Hi, > > The Vital Product Data (VPD) sysfs file is not readable by unprivileged > users. This limitation is not necessary and can be removed at least for > devices which are known as safe. > > Thanks > > Leon Romanovsky (2): > PCI/sysfs: Change read permissions for VPD attributes > net/mlx5: Enable unprivileged read of PCI VPD file > > drivers/net/ethernet/mellanox/mlx5/core/main.c | 1 + > drivers/pci/vpd.c | 9 ++++++++- > include/linux/pci.h | 7 ++++++- > 3 files changed, 15 insertions(+), 2 deletions(-) Bjorn, Does this version resolve your concerns about broken devices in the field? Thanks > > -- > 2.47.0 > >