From: Jakub Kicinski <kuba@kernel.org>
To: Petr Machata <petrm@nvidia.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, <netdev@vger.kernel.org>,
Simon Horman <horms@kernel.org>, Ido Schimmel <idosch@nvidia.com>,
Amit Cohen <amcohen@nvidia.com>,
Vladimir Oltean <vladimir.oltean@nxp.com>,
Andy Roulin <aroulin@nvidia.com>, <mlxsw@nvidia.com>,
Shuah Khan <skhan@linuxfoundation.org>,
Shuah Khan <shuah@kernel.org>,
Benjamin Poirier <bpoirier@nvidia.com>,
Hangbin Liu <liuhangbin@gmail.com>,
<linux-kselftest@vger.kernel.org>, Jiri Pirko <jiri@resnulli.us>
Subject: Re: [PATCH net-next v3 7/7] selftests: net: fdb_notify: Add a test for FDB notifications
Date: Tue, 12 Nov 2024 14:22:34 -0800 [thread overview]
Message-ID: <20241112142234.7abf2232@kernel.org> (raw)
In-Reply-To: <baf2abd6af2e88f8874d14c97da1554b7e7a710e.1731342342.git.petrm@nvidia.com>
On Mon, 11 Nov 2024 18:09:01 +0100 Petr Machata wrote:
> Check that only one notification is produced for various FDB edit
> operations.
>
> Regarding the ip_link_add() and ip_link_master() helpers. This pattern of
> action plus corresponding defer is bound to come up often, and a dedicated
> vocabulary to capture it will be handy. tunnel_create() and vlan_create()
> from forwarding/lib.sh are somewhat opaque and perhaps too kitchen-sinky,
> so I tried to go in the opposite direction with these ones, and wrapped
> only the bare minimum to schedule a corresponding cleanup.
Looks like it fails about half of the time :(
https://netdev.bots.linux.dev/flakes.html?min-flip=0&tn-needle=fdb-notify&br-cnt=200
--
pw-bot: cr
next prev parent reply other threads:[~2024-11-12 22:22 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-11 17:08 [PATCH net-next v3 0/7] net: ndo_fdb_add/del: Have drivers report whether they notified Petr Machata
2024-11-11 17:08 ` [PATCH net-next v3 1/7] ndo_fdb_add: Add a parameter to report whether notification was sent Petr Machata
2024-11-12 13:56 ` Nikolay Aleksandrov
2024-11-11 17:08 ` [PATCH net-next v3 2/7] ndo_fdb_del: " Petr Machata
2024-11-12 13:56 ` Nikolay Aleksandrov
2024-11-11 17:08 ` [PATCH net-next v3 3/7] selftests: net: lib: Move logging from forwarding/lib.sh here Petr Machata
2024-11-11 17:08 ` [PATCH net-next v3 4/7] selftests: net: lib: Move tests_run " Petr Machata
2024-11-11 17:08 ` [PATCH net-next v3 5/7] selftests: net: lib: Move checks " Petr Machata
2024-11-11 17:09 ` [PATCH net-next v3 6/7] selftests: net: lib: Add kill_process Petr Machata
2024-11-11 17:09 ` [PATCH net-next v3 7/7] selftests: net: fdb_notify: Add a test for FDB notifications Petr Machata
2024-11-12 22:22 ` Jakub Kicinski [this message]
2024-11-13 11:46 ` Petr Machata
2024-11-13 15:11 ` Petr Machata
2024-11-14 1:08 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241112142234.7abf2232@kernel.org \
--to=kuba@kernel.org \
--cc=amcohen@nvidia.com \
--cc=aroulin@nvidia.com \
--cc=bpoirier@nvidia.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=idosch@nvidia.com \
--cc=jiri@resnulli.us \
--cc=linux-kselftest@vger.kernel.org \
--cc=liuhangbin@gmail.com \
--cc=mlxsw@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
--cc=shuah@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).