From: Jakub Kicinski <kuba@kernel.org>
To: Rosen Penev <rosenp@gmail.com>
Cc: netdev@vger.kernel.org, Marc Kleine-Budde <mkl@pengutronix.de>,
Vincent Mailhol <mailhol.vincent@wanadoo.fr>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Florian Fainelli <florian.fainelli@broadcom.com>,
Vladimir Oltean <olteanv@gmail.com>, Chen-Yu Tsai <wens@csie.org>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Samuel Holland <samuel@sholland.org>,
Pantelis Antoniou <pantelis.antoniou@gmail.com>,
Marcin Wojtas <marcin.s.wojtas@gmail.com>,
Byungho An <bh74.an@samsung.com>,
Kevin Brace <kevinbrace@bracecomputerlab.com>,
Francois Romieu <romieu@fr.zoreil.com>,
Michal Simek <michal.simek@amd.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
Zhao Qiang <qiang.zhao@nxp.com>,
linux-can@vger.kernel.org (open list:CAN NETWORK DRIVERS),
linux-kernel@vger.kernel.org (open list),
linux-arm-kernel@lists.infradead.org (moderated
list:ARM/Allwinner sunXi SoC support),
linux-sunxi@lists.linux.dev (open list:ARM/Allwinner sunXi SoC
support),
linuxppc-dev@lists.ozlabs.org (open list:FREESCALE SOC FS_ENET
DRIVER)
Subject: Re: [PATCHv3 net-next] net: modernize IRQ resource acquisition
Date: Tue, 12 Nov 2024 17:23:02 -0800 [thread overview]
Message-ID: <20241112172302.582285d3@kernel.org> (raw)
In-Reply-To: <20241112211442.7205-1-rosenp@gmail.com>
On Tue, 12 Nov 2024 13:14:42 -0800 Rosen Penev wrote:
> drivers/net/ethernet/moxa/moxart_ether.c | 6 ++---
> .../ethernet/samsung/sxgbe/sxgbe_platform.c | 24 +++++++------------
coccicheck says:
drivers/net/ethernet/samsung/sxgbe/sxgbe_platform.c:130:6-26: WARNING: Unsigned expression compared with zero: priv -> rxq [ i ] -> irq_no < 0
drivers/net/ethernet/samsung/sxgbe/sxgbe_platform.c:124:6-26: WARNING: Unsigned expression compared with zero: priv -> txq [ i ] -> irq_no < 0
drivers/net/ethernet/moxa/moxart_ether.c:468:5-8: WARNING: Unsigned expression compared with zero: irq < 0
Is this really worth the review effort? :|
Please do not send any more conversions unless the old API is clearly
deprecated.
--
pw-bot: cr
next prev parent reply other threads:[~2024-11-13 1:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-12 21:14 [PATCHv3 net-next] net: modernize IRQ resource acquisition Rosen Penev
2024-11-12 21:42 ` Florian Fainelli
2024-11-13 1:23 ` Jakub Kicinski [this message]
2024-11-13 7:14 ` Marc Kleine-Budde
2024-11-13 9:48 ` Julian Calaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241112172302.582285d3@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=bh74.an@samsung.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=florian.fainelli@broadcom.com \
--cc=hkallweit1@gmail.com \
--cc=jernej.skrabec@gmail.com \
--cc=kevinbrace@bracecomputerlab.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=linux@armlinux.org.uk \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mailhol.vincent@wanadoo.fr \
--cc=marcin.s.wojtas@gmail.com \
--cc=michal.simek@amd.com \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=pantelis.antoniou@gmail.com \
--cc=qiang.zhao@nxp.com \
--cc=romieu@fr.zoreil.com \
--cc=rosenp@gmail.com \
--cc=samuel@sholland.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).