From: Jakub Kicinski <kuba@kernel.org>
To: Joe Damato <jdamato@fastly.com>
Cc: netdev@vger.kernel.org, pabeni@redhat.com, edumazet@google.com,
amritha.nambiar@intel.com, sridhar.samudrala@intel.com,
mkarsten@uwaterloo.ca, stable@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Simon Horman <horms@kernel.org>,
Mina Almasry <almasrymina@google.com>,
linux-kernel@vger.kernel.org (open list)
Subject: Re: [RFC net 1/2] netdev-genl: Hold rcu_read_lock in napi_get
Date: Tue, 12 Nov 2024 17:28:40 -0800 [thread overview]
Message-ID: <20241112172840.0cf9731f@kernel.org> (raw)
In-Reply-To: <20241112181401.9689-2-jdamato@fastly.com>
On Tue, 12 Nov 2024 18:13:58 +0000 Joe Damato wrote:
> +/* must be called under rcu_read_lock(), because napi_by_id requires it */
> +static struct napi_struct *__do_napi_by_id(unsigned int napi_id,
> + struct genl_info *info, int *err)
> +{
> + struct napi_struct *napi;
> +
> + napi = napi_by_id(napi_id);
> + if (napi) {
> + *err = 0;
> + } else {
> + NL_SET_BAD_ATTR(info->extack, info->attrs[NETDEV_A_NAPI_ID]);
> + *err = -ENOENT;
> + }
> +
> + return napi;
> +}
Thanks for the quick follow up! I vote we don't factor this out.
I don't see what it buys us, TBH, normally we factor out code
to avoid having to unlock before return, but this code doesn't
have extra returns...
Just slap an rcu_read_lock / unlock around and that's it?
Feel free to repost soon.
next prev parent reply other threads:[~2024-11-13 1:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-12 18:13 [RFC net 0/2] Fix rcu_read_lock issues in netdev-genl Joe Damato
2024-11-12 18:13 ` [RFC net 1/2] netdev-genl: Hold rcu_read_lock in napi_get Joe Damato
2024-11-13 1:28 ` Jakub Kicinski [this message]
2024-11-13 1:48 ` Joe Damato
2024-11-13 2:01 ` Jakub Kicinski
2024-11-13 2:05 ` Joe Damato
2024-11-12 18:13 ` [RFC net 2/2] netdev-genl: Hold rcu_read_lock in napi_set Joe Damato
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241112172840.0cf9731f@kernel.org \
--to=kuba@kernel.org \
--cc=almasrymina@google.com \
--cc=amritha.nambiar@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jdamato@fastly.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mkarsten@uwaterloo.ca \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sridhar.samudrala@intel.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).