* [PATCH net] samples: pktgen: correct dev to DEV
@ 2024-11-12 3:03 Wei Fang
2024-11-12 17:35 ` Simon Horman
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Wei Fang @ 2024-11-12 3:03 UTC (permalink / raw)
To: davem, edumazet, kuba, pabeni, horms, hawk, lorenzo
Cc: netdev, linux-kernel, imx
In the pktgen_sample01_simple.sh script, the device variable is uppercase
'DEV' instead of lowercase 'dev'. Because of this typo, the script cannot
enable UDP tx checksum.
Fixes: 460a9aa23de6 ("samples: pktgen: add UDP tx checksum support")
Signed-off-by: Wei Fang <wei.fang@nxp.com>
---
samples/pktgen/pktgen_sample01_simple.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/samples/pktgen/pktgen_sample01_simple.sh b/samples/pktgen/pktgen_sample01_simple.sh
index cdb9f497f87d..66cb707479e6 100755
--- a/samples/pktgen/pktgen_sample01_simple.sh
+++ b/samples/pktgen/pktgen_sample01_simple.sh
@@ -76,7 +76,7 @@ if [ -n "$DST_PORT" ]; then
pg_set $DEV "udp_dst_max $UDP_DST_MAX"
fi
-[ ! -z "$UDP_CSUM" ] && pg_set $dev "flag UDPCSUM"
+[ ! -z "$UDP_CSUM" ] && pg_set $DEV "flag UDPCSUM"
# Setup random UDP port src range
pg_set $DEV "flag UDPSRC_RND"
--
2.34.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH net] samples: pktgen: correct dev to DEV
2024-11-12 3:03 [PATCH net] samples: pktgen: correct dev to DEV Wei Fang
@ 2024-11-12 17:35 ` Simon Horman
2024-11-13 9:44 ` Jesper Dangaard Brouer
2024-11-14 3:10 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 6+ messages in thread
From: Simon Horman @ 2024-11-12 17:35 UTC (permalink / raw)
To: Wei Fang
Cc: davem, edumazet, kuba, pabeni, hawk, lorenzo, netdev,
linux-kernel, imx
On Tue, Nov 12, 2024 at 11:03:47AM +0800, Wei Fang wrote:
> In the pktgen_sample01_simple.sh script, the device variable is uppercase
> 'DEV' instead of lowercase 'dev'. Because of this typo, the script cannot
> enable UDP tx checksum.
>
> Fixes: 460a9aa23de6 ("samples: pktgen: add UDP tx checksum support")
> Signed-off-by: Wei Fang <wei.fang@nxp.com>
Reviewed-by: Simon Horman <horms@kernel.org>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH net] samples: pktgen: correct dev to DEV
2024-11-12 3:03 [PATCH net] samples: pktgen: correct dev to DEV Wei Fang
2024-11-12 17:35 ` Simon Horman
@ 2024-11-13 9:44 ` Jesper Dangaard Brouer
2024-11-13 10:06 ` Wei Fang
2024-11-14 3:10 ` patchwork-bot+netdevbpf
2 siblings, 1 reply; 6+ messages in thread
From: Jesper Dangaard Brouer @ 2024-11-13 9:44 UTC (permalink / raw)
To: Wei Fang, davem, edumazet, kuba, pabeni, horms, lorenzo
Cc: netdev, linux-kernel, imx
On 12/11/2024 04.03, Wei Fang wrote:
> In the pktgen_sample01_simple.sh script, the device variable is uppercase
> 'DEV' instead of lowercase 'dev'. Because of this typo, the script cannot
> enable UDP tx checksum.
>
> Fixes: 460a9aa23de6 ("samples: pktgen: add UDP tx checksum support")
> Signed-off-by: Wei Fang <wei.fang@nxp.com>
> ---
> samples/pktgen/pktgen_sample01_simple.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/samples/pktgen/pktgen_sample01_simple.sh b/samples/pktgen/pktgen_sample01_simple.sh
> index cdb9f497f87d..66cb707479e6 100755
> --- a/samples/pktgen/pktgen_sample01_simple.sh
> +++ b/samples/pktgen/pktgen_sample01_simple.sh
Why are you only fixing one script?
The fixes commit 460a9aa23de6 changes many files, introducing this bug.
> @@ -76,7 +76,7 @@ if [ -n "$DST_PORT" ]; then
> pg_set $DEV "udp_dst_max $UDP_DST_MAX"
> fi
>
> -[ ! -z "$UDP_CSUM" ] && pg_set $dev "flag UDPCSUM"
> +[ ! -z "$UDP_CSUM" ] && pg_set $DEV "flag UDPCSUM"
>
This fix looks correct, but we also need to fix other scripts
> # Setup random UDP port src range
> pg_set $DEV "flag UDPSRC_RND"
$ git whatchanged -1 460a9aa23de6 | grep 'M samples'| awk -FM
'{print $2}'
samples/pktgen/parameters.sh
samples/pktgen/pktgen_sample01_simple.sh
samples/pktgen/pktgen_sample02_multiqueue.sh
samples/pktgen/pktgen_sample03_burst_single_flow.sh
samples/pktgen/pktgen_sample04_many_flows.sh
samples/pktgen/pktgen_sample05_flow_per_thread.sh
samples/pktgen/pktgen_sample06_numa_awared_queue_irq_affinity.sh
Thanks for spotting this, but please also fix the other scripts :-)
--Jesper
^ permalink raw reply [flat|nested] 6+ messages in thread* RE: [PATCH net] samples: pktgen: correct dev to DEV
2024-11-13 9:44 ` Jesper Dangaard Brouer
@ 2024-11-13 10:06 ` Wei Fang
2024-11-13 12:19 ` Jesper Dangaard Brouer
0 siblings, 1 reply; 6+ messages in thread
From: Wei Fang @ 2024-11-13 10:06 UTC (permalink / raw)
To: Jesper Dangaard Brouer
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
imx@lists.linux.dev, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, horms@kernel.org,
lorenzo@kernel.org
> On 12/11/2024 04.03, Wei Fang wrote:
> > In the pktgen_sample01_simple.sh script, the device variable is
> > uppercase 'DEV' instead of lowercase 'dev'. Because of this typo, the
> > script cannot enable UDP tx checksum.
> >
> > Fixes: 460a9aa23de6 ("samples: pktgen: add UDP tx checksum support")
> > Signed-off-by: Wei Fang <wei.fang@nxp.com>
> > ---
> > samples/pktgen/pktgen_sample01_simple.sh | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/samples/pktgen/pktgen_sample01_simple.sh
> > b/samples/pktgen/pktgen_sample01_simple.sh
> > index cdb9f497f87d..66cb707479e6 100755
> > --- a/samples/pktgen/pktgen_sample01_simple.sh
> > +++ b/samples/pktgen/pktgen_sample01_simple.sh
>
> Why are you only fixing one script?
>
Other scripts are correct, because they are all multi-threaded, "dev" is
defined for each thread like below.
dev=${DEV}@${thread}
> The fixes commit 460a9aa23de6 changes many files, introducing this bug.
>
> > @@ -76,7 +76,7 @@ if [ -n "$DST_PORT" ]; then
> > pg_set $DEV "udp_dst_max $UDP_DST_MAX"
> > fi
> >
> > -[ ! -z "$UDP_CSUM" ] && pg_set $dev "flag UDPCSUM"
> > +[ ! -z "$UDP_CSUM" ] && pg_set $DEV "flag UDPCSUM"
> >
>
> This fix looks correct, but we also need to fix other scripts
>
> > # Setup random UDP port src range
> > pg_set $DEV "flag UDPSRC_RND"
>
>
> $ git whatchanged -1 460a9aa23de6 | grep 'M samples'| awk -FM
> '{print $2}'
> samples/pktgen/parameters.sh
> samples/pktgen/pktgen_sample01_simple.sh
> samples/pktgen/pktgen_sample02_multiqueue.sh
> samples/pktgen/pktgen_sample03_burst_single_flow.sh
> samples/pktgen/pktgen_sample04_many_flows.sh
> samples/pktgen/pktgen_sample05_flow_per_thread.sh
> samples/pktgen/pktgen_sample06_numa_awared_queue_irq_affinity.sh
>
> Thanks for spotting this, but please also fix the other scripts :-)
>
> --Jesper
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH net] samples: pktgen: correct dev to DEV
2024-11-13 10:06 ` Wei Fang
@ 2024-11-13 12:19 ` Jesper Dangaard Brouer
0 siblings, 0 replies; 6+ messages in thread
From: Jesper Dangaard Brouer @ 2024-11-13 12:19 UTC (permalink / raw)
To: Wei Fang
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
imx@lists.linux.dev, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, horms@kernel.org,
lorenzo@kernel.org
On 13/11/2024 11.06, Wei Fang wrote:
>> On 12/11/2024 04.03, Wei Fang wrote:
>>> In the pktgen_sample01_simple.sh script, the device variable is
>>> uppercase 'DEV' instead of lowercase 'dev'. Because of this typo, the
>>> script cannot enable UDP tx checksum.
>>>
>>> Fixes: 460a9aa23de6 ("samples: pktgen: add UDP tx checksum support")
>>> Signed-off-by: Wei Fang <wei.fang@nxp.com>
>>> ---
>>> samples/pktgen/pktgen_sample01_simple.sh | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/samples/pktgen/pktgen_sample01_simple.sh
>>> b/samples/pktgen/pktgen_sample01_simple.sh
>>> index cdb9f497f87d..66cb707479e6 100755
>>> --- a/samples/pktgen/pktgen_sample01_simple.sh
>>> +++ b/samples/pktgen/pktgen_sample01_simple.sh
>>
>> Why are you only fixing one script?
>>
>
> Other scripts are correct, because they are all multi-threaded, "dev" is
> defined for each thread like below.
>
> dev=${DEV}@${thread}
>
Good point! - then this patch is enough :-)
Acked-by: Jesper Dangaard Brouer <hawk@kernel.org>
Thanks for fixing this,
--Jesper
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH net] samples: pktgen: correct dev to DEV
2024-11-12 3:03 [PATCH net] samples: pktgen: correct dev to DEV Wei Fang
2024-11-12 17:35 ` Simon Horman
2024-11-13 9:44 ` Jesper Dangaard Brouer
@ 2024-11-14 3:10 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 6+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-11-14 3:10 UTC (permalink / raw)
To: Wei Fang
Cc: davem, edumazet, kuba, pabeni, horms, hawk, lorenzo, netdev,
linux-kernel, imx
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Tue, 12 Nov 2024 11:03:47 +0800 you wrote:
> In the pktgen_sample01_simple.sh script, the device variable is uppercase
> 'DEV' instead of lowercase 'dev'. Because of this typo, the script cannot
> enable UDP tx checksum.
>
> Fixes: 460a9aa23de6 ("samples: pktgen: add UDP tx checksum support")
> Signed-off-by: Wei Fang <wei.fang@nxp.com>
>
> [...]
Here is the summary with links:
- [net] samples: pktgen: correct dev to DEV
https://git.kernel.org/netdev/net/c/3342dc8b4623
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-11-14 3:10 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-11-12 3:03 [PATCH net] samples: pktgen: correct dev to DEV Wei Fang
2024-11-12 17:35 ` Simon Horman
2024-11-13 9:44 ` Jesper Dangaard Brouer
2024-11-13 10:06 ` Wei Fang
2024-11-13 12:19 ` Jesper Dangaard Brouer
2024-11-14 3:10 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).