From: Jakub Kicinski <kuba@kernel.org>
To: Jamal Hadi Salim <jhs@mojatatu.com>
Cc: Alexandre Ferrieux <alexandre.ferrieux@gmail.com>,
Eric Dumazet <edumazet@google.com>,
Cong Wang <xiyou.wangcong@gmail.com>,
Jiri Pirko <jiri@resnulli.us>,
alexandre.ferrieux@orange.com,
Linux Kernel Network Developers <netdev@vger.kernel.org>,
Simon Horman <horms@verge.net.au>, Andrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCH net v6] net: sched: cls_u32: Fix u32's systematic failure to free IDR entries for hnodes.
Date: Tue, 12 Nov 2024 17:57:13 -0800 [thread overview]
Message-ID: <20241112175713.6542a5cf@kernel.org> (raw)
In-Reply-To: <CAM0EoMkQUqpkGJADfYUupp5zP7vZdd7=4MVo5TTJbWqEYDkq7g@mail.gmail.com>
On Tue, 12 Nov 2024 12:07:10 -0500 Jamal Hadi Salim wrote:
> On Tue, Nov 12, 2024 at 10:18 AM Jakub Kicinski <kuba@kernel.org> wrote:
> > I'm used to merging the fix with the selftest, two minor reasons pro:
> > - less burden on submitter
> > - backporters can see and use the test to validate, immediately
> > con:
> > - higher risk of conflicts, but that's my problem (we really need to
> > alpha-sort the makefiles, sigh)
>
> Sounds sensible to me - would help to burn it into scripture.
How does this sound?
Co-posting selftests
--------------------
Selftests should be part of the same series as the code changes.
Specifically for fixes both code change and related test should go into
the same tree (the tests may lack a Fixes tag, which is expected).
Mixing code changes and test changes in a single commit is discouraged.
next prev parent reply other threads:[~2024-11-13 1:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-08 14:11 [PATCH net v6] net: sched: cls_u32: Fix u32's systematic failure to free IDR entries for hnodes Alexandre Ferrieux
2024-11-09 12:50 ` Jamal Hadi Salim
2024-11-09 15:39 ` Alexandre Ferrieux
2024-11-11 18:26 ` Jakub Kicinski
2024-11-12 12:23 ` Jamal Hadi Salim
2024-11-12 13:48 ` Alexandre Ferrieux
2024-11-12 15:18 ` Jakub Kicinski
2024-11-12 17:07 ` Jamal Hadi Salim
2024-11-13 1:57 ` Jakub Kicinski [this message]
2024-11-13 10:12 ` Alexandre Ferrieux
2024-11-13 14:17 ` Jamal Hadi Salim
2024-11-14 0:41 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241112175713.6542a5cf@kernel.org \
--to=kuba@kernel.org \
--cc=alexandre.ferrieux@gmail.com \
--cc=alexandre.ferrieux@orange.com \
--cc=andrew@lunn.ch \
--cc=edumazet@google.com \
--cc=horms@verge.net.au \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).