From: Jakub Kicinski <kuba@kernel.org>
To: Paolo Abeni <pabeni@redhat.com>
Cc: Guillaume Nault <gnault@redhat.com>,
David Miller <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
netdev@vger.kernel.org, Simon Horman <horms@kernel.org>,
Andrew Lunn <andrew+netdev@lunn.ch>
Subject: Re: [PATCH net-next] geneve: Use pcpu stats to update rx_dropped counter.
Date: Tue, 12 Nov 2024 18:15:18 -0800 [thread overview]
Message-ID: <20241112181518.3f55a359@kernel.org> (raw)
In-Reply-To: <a6bd2ee8-c732-4922-9e7c-ae89a1ad8056@redhat.com>
On Tue, 12 Nov 2024 17:53:36 +0100 Paolo Abeni wrote:
> > How about switching to NETDEV_PCPU_STAT_DSTATS instead, so there is a
> > single percpu struct allocated x device (geneve already uses
> > NETDEV_PCPU_STAT_TSTATS): stats fetching will be faster, and possibly
> > memory usage lower.
>
> I was not aware of the previous discussion on this same topic:
>
> https://lore.kernel.org/netdev/20240903113402.41d19129@kernel.org/
>
> and I missed the previous change on bareudp.c
>
> I still think that avoiding the double per-cpu traversal when fetching
> the stats could be useful, especially on large multi-numa nodes systems.
>
> I guess it's better to be consistent and keep geneve and bareudp
> aligned. We can eventually consolidate the stats later.
We merged the bareudp changes... begrudgingly. You're the third
maintainer in a row to make a similar suggestion, which is pretty
strong signal that it's a better direction.
next prev parent reply other threads:[~2024-11-13 2:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-07 11:41 [PATCH net-next] geneve: Use pcpu stats to update rx_dropped counter Guillaume Nault
2024-11-08 20:29 ` Simon Horman
2024-11-12 10:53 ` Paolo Abeni
2024-11-12 16:53 ` Paolo Abeni
2024-11-13 2:15 ` Jakub Kicinski [this message]
2024-11-13 14:22 ` Guillaume Nault
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241112181518.3f55a359@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gnault@redhat.com \
--cc=horms@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).