From: Simon Horman <horms@kernel.org>
To: Wenjia Zhang <wenjia@linux.ibm.com>
Cc: Manas <manas18244@iiitd.ac.in>, Jan Karcher <jaka@linux.ibm.com>,
"D. Wythe" <alibuda@linux.alibaba.com>,
Tony Lu <tonylu@linux.alibaba.com>,
Wen Gu <guwen@linux.alibaba.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Shuah Khan <shuah@kernel.org>,
Anup Sharma <anupnewsmail@gmail.com>,
linux-s390@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Remove unused function parameter in __smc_diag_dump
Date: Tue, 12 Nov 2024 18:22:18 +0000 [thread overview]
Message-ID: <20241112182218.GV4507@kernel.org> (raw)
In-Reply-To: <538b7781-0d57-45e6-a00a-fb03c0c30a52@linux.ibm.com>
On Tue, Nov 12, 2024 at 08:36:13AM +0100, Wenjia Zhang wrote:
>
>
> On 11.11.24 16:10, Manas wrote:
> > On 11.11.2024 15:11, Wenjia Zhang wrote:
...
> > Thank you Wenjia for reviewing this.
> >
> > Should I make any changes to the commit message if we are going forward
> > with it
> > being as a cleanup patch? The commit message itself (barring the cover
> > letter)
> > should be enough, I reckon.
> >
> I think it is ok as it is.
Yes, agreed.
The commit message should be truncated at first scissors ("---").
Which leaves us with a commit message only describing the removal
of an unused function parameter. Which, given the discussion in
this thread, is what we want.
Reviewed-by: Simon Horman <horms@kernel.org>
>
> Thanks,
> Wenjia
>
prev parent reply other threads:[~2024-11-12 18:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-09 6:28 [PATCH] Remove unused function parameter in __smc_diag_dump Manas via B4 Relay
2024-11-11 13:04 ` Jeongjun Park
2024-11-11 15:06 ` Manas
2024-11-11 14:11 ` Wenjia Zhang
2024-11-11 15:10 ` Manas
2024-11-12 7:36 ` Wenjia Zhang
2024-11-12 18:22 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241112182218.GV4507@kernel.org \
--to=horms@kernel.org \
--cc=alibuda@linux.alibaba.com \
--cc=anupnewsmail@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=guwen@linux.alibaba.com \
--cc=jaka@linux.ibm.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=manas18244@iiitd.ac.in \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
--cc=tonylu@linux.alibaba.com \
--cc=wenjia@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).